Validate SSL config for sanity before startup

02cdec5a10ae886aff84896d485738213331c2ba

Cohee <18619528+Cohee1207@users.noreply.github.com>

Parents: 813ec537cd1c8c41d2409559fd46a3d50b9ada84

src/server-startup.js+39 -10 Viewed

+    }
     /**
 +     * Prints a fatal error message and exits the process.
 +     * @param {string} message
 +     */
 +    #fatal(message) {
 +        console.error(color.red(message));
 +        process.exit(1);
 +    }
++
 +    /**
 +     * Checks if SSL options are valid. If not, it will print an error message and exit the process.
 +     * @returns {void}
 +     */
 +    #verifySslOptions() {
 +        if (!this.cliArgs.ssl) return;
++
 +        if (!this.cliArgs.certPath) {
 +            this.#fatal('Error: SSL certificate path is required when using HTTPS. Check your config');
 +        }
++
 +        if (!this.cliArgs.keyPath) {
 +            this.#fatal('Error: SSL key path is required when using HTTPS. Check your config');
 +        }
++
 +        if (!fs.existsSync(this.cliArgs.certPath)) {
 +            this.#fatal('Error: SSL certificate path does not exist');
 +        }
++
 +        if (!fs.existsSync(this.cliArgs.keyPath)) {
 +            this.#fatal('Error: SSL key path does not exist');
 +        }
 +    }
++
 +    /**
      * Creates an HTTPS server.
      * @param {URL} url The URL to listen on
      * @param {number} ipVersion the ip version to use
      * @returns {Promise<void>} A promise that resolves when the server is listening
 -     * @throws {Error} If the server fails to start
      */
     #createHttpsServer(url, ipVersion) {
 +        this.#verifySslOptions();
         return new Promise((resolve, reject) => {
             const sslOptions = {
                 cert: fs.readFileSync(this.cliArgs.certPath),

      * @param {URL} url The URL to listen on
      * @param {number} ipVersion the ip version to use
      * @returns {Promise<void>} A promise that resolves when the server is listening
 -     * @throws {Error} If the server fails to start
      */
     #createHttpServer(url, ipVersion) {
         return new Promise((resolve, reject) => {

             try {
                 await createFunc(this.cliArgs.getIPv6ListenUrl(), 6);
             } catch (error) {
                 console.error('non-fatal errorWarning: failed to start server on IPv6');
                 console.error(error);
                 v6Failed = true;

             try {
                 await createFunc(this.cliArgs.getIPv4ListenUrl(), 4);
             } catch (error) {
                 console.error('non-fatal errorWarning: failed to start server on IPv4');
                 console.error(error);
                 v4Failed = true;

@@ -285,18 +317,15 @@ export class ServerStartup {
285	317	*/
286	318	#handleServerListenFail({ v6Failed, v4Failed, useIPv6, useIPv4 }) {
287	319	if (v6Failed && !useIPv4) {
288	320	console.error(colorthis.red#fatal('fatal errorError: Failed to start server on IPv6 and IPv4 disabled'));
289		- process.exit(1);
290	321	}
291	322
292	323	if (v4Failed && !useIPv6) {
293	324	console.error(colorthis.red#fatal('fatal errorError: Failed to start server on IPv4 and IPv6 disabled'));
294		- process.exit(1);
295	325	}
296	326
297	327	if (v6Failed && v4Failed) {
298	328	console.error(colorthis.red#fatal('fatal errorError: Failed to start server on both IPv6 and IPv4'));
299		- process.exit(1);
300	329	}
301	330	}
302	331