fix: timeout git process after 5 minutes of inactivity (#4673) * fix: timeout git process after 10 seconds of inactivity * fix: increase git process timeout to 10 minutes * 10->5 min, remove timeout from install

034a5f3aa416fa858a86f62513a9402920be8ec8

Cohee <18619528+Cohee1207@users.noreply.github.com>

Signed

src/endpoints/extensions.js+11 -5 Viewed

 import { PUBLIC_DIRECTORIES } from '../constants.js';
 /**
+ * @type {Partial<import('simple-git').SimpleGitOptions>}
+ */
+const OPTIONS = Object.freeze({ timeout: { block: 5 * 60 * 1000 } });
+/**
  * This function extracts the extension information from the manifest file.
  * @param {string} extensionPath - The path of the extension folder
  * @returns {Promise<Object>} - Returns the manifest data as an object

  * @returns {Promise<Object>} - Returns the extension information as an object
  */
 async function checkIfRepoIsUpToDate(extensionPath) {
-    const git = simpleGit({ baseDir: extensionPath });
+    const git = simpleGit({ baseDir: extensionPath, ...OPTIONS });
     await git.fetch('origin');
     const currentBranch = await git.branch();
     const currentCommitHash = await git.revparse(['HEAD']);

+    }
     try {
+        // No timeout for cloning, as it may take a while depending on the repo size
         const git = simpleGit();
         // make sure the third-party directory exists

+        }
         const { isUpToDate, remoteUrl } = await checkIfRepoIsUpToDate(extensionPath);
-        const git = simpleGit({ baseDir: extensionPath });
+        const git = simpleGit({ baseDir: extensionPath, ...OPTIONS });
         const isRepo = await git.checkIsRepo(CheckRepoActions.IS_REPO_ROOT);
         if (!isRepo) {
             throw new Error(`Directory is not a Git repository at ${extensionPath}`);

             return response.status(404).send(`Directory does not exist at ${extensionPath}`);
+        }
-        const git = simpleGit({ baseDir: extensionPath });
+        const git = simpleGit({ baseDir: extensionPath, ...OPTIONS });
         // Unshallow the repository if it is shallow
         const isShallow = await git.revparse(['--is-shallow-repository']) === 'true';
         if (isShallow) {

             return response.status(404).send(`Directory does not exist at ${extensionPath}`);
+        }
-        const git = simpleGit({ baseDir: extensionPath });
+        const git = simpleGit({ baseDir: extensionPath, ...OPTIONS });
         const branches = await git.branchLocal();
         if (String(branch).startsWith('origin/')) {

             return response.status(404).send(`Directory does not exist at ${extensionPath}`);
+        }
-        const git = simpleGit({ baseDir: extensionPath });
+        const git = simpleGit({ baseDir: extensionPath, ...OPTIONS });
         let currentCommitHash;
         try {
             const isRepo = await git.checkIsRepo(CheckRepoActions.IS_REPO_ROOT);