Why join and then split again, eh? - Refactor /add actually using the array provided as the array for the internal `parseNumericSeries` inside `performOperation`

0d38e634714ccb254799b390293066e54912bc37

Wolfsblvt <wolfsblvt@gmail.com>

public/scripts/variables.js+5 -6 Viewed

+}
 /**
- * Parses a series of numeric values from a string.
+ * Parses a series of numeric values from a string or a string array.
- * @param {string} value A space-separated list of numeric values or variable names
+ * @param {string|string[]} value A space-separated list of numeric values or variable names
  * @param {SlashCommandScope} scope Scope
  * @returns {number[]} An array of numeric values
  */

         return [value];
+    }
-    const array = value
+    const values = Array.isArray(value) ? value : value.split(' ');
-        .split(' ')
+    const array = values.map(i => i.trim())
-        .map(i => i.trim())
         .filter(i => i !== '')
         .map(i => isNaN(Number(i)) ? Number(resolveVariable(i, scope)) : Number(i))
         .filter(i => !isNaN(i));

     }));
     SlashCommandParser.addCommandObject(SlashCommand.fromProps({
         name: 'add',
-        callback: (args, /**@type {string[]}*/value) => addValuesCallback(args, value.join(' ')),
+        callback: (args, value) => addValuesCallback(args, value),
         returns: 'sum of the provided values',
         unnamedArgumentList: [
             SlashCommandArgument.fromProps({