Filter out inapplicable stop strings for Chat Completion (#5337) * Stop strings apply to Chat Completions and should not be greyed out. * Revert "Stop strings apply to Chat Completions and should not be greyed out." This reverts commit 51e5cfee41e1298b0005ff9df5d783c08820ed9a. * Stopping strings should only apply to Text Completions https://github.com/SillyTavern/SillyTavern/pull/5337#pullrequestreview-3987164461 * Custom stop strings still apply * Also apply to non-streaming message clean-up * This comment is now misplaced * Oops, wrong file * Revert package-lock change --------- Co-authored-by: user <user@exmaple.com> Co-authored-by: Cohee <18619528+Cohee1207@users.noreply.github.com>

0e5928b13a2000c964eb64b1caf64969134ea0c1

DeclineThyself <235079501+DeclineThyself@users.noreply.github.com>

Signed

public/script.js+9 -3 Viewed

  * Gets stopping sequences for the prompt.
  * @param {boolean} isImpersonate A request is made to impersonate a user
  * @param {boolean} isContinue A request is made to continue the message
 + * @param {string} [api] Optional API name to get API-specific stopping sequences for
  * @returns {string[]} Array of stopping strings
  */
 export function getStoppingStrings(isImpersonate, isContinue, api = main_api) {
 +    // Only custom stop strings apply to Chat Completion
 +    if (api === 'openai') {
 +        return getCustomStoppingStrings();
 +    }
++
     const result = [];
     if (power_user.context.names_as_stop_strings) {

         // when streaming, we cache the result of getStoppingStrings instead of calling it once per token.
         const isImpersonate = this.type == 'impersonate';
         const isContinue = this.type == 'continue';
         this.stoppingStrings = getStoppingStrings(isImpersonate, isContinue, main_api);
         try {
             const sw = new Stopwatch(1000 / power_user.streaming_fps);

     // Allow for caching of stopping strings. getStoppingStrings is an expensive function, especially with macros
     // enabled, so for streaming, we call it once and then pass it into each cleanUpMessage call.
     if (!stoppingStrings) {
         stoppingStrings = getStoppingStrings(isImpersonate, isContinue, main_api);
+    }
     for (const stoppingString of stoppingStrings) {