Merge pull request #3778 from SillyTavern/fix/persona-select-rerender-first-message Fix persona select on new chat not rerendering first message (and not replacing `{{user}}` macro)

157046ff46f56af20fc371272f7974f3ed707442

Cohee <18619528+Cohee1207@users.noreply.github.com>

Signed

public/scripts/personas.js+8 -13 Viewed

     reloadUserAvatar();
     updatePersonaUIStates({ navigateToCurrent: navigateToCurrent });
     selectCurrentPersona({ toastPersonaNameChange: toastPersonaNameChange });
+    retriggerFirstMessageOnEmptyChat();
     saveSettingsDebounced();
     $('.zoomed_avatar[forchar]').remove();
+}

  * @returns {Promise<boolean>} A promise that resolves to true if the character was converted, false otherwise.
  */
 export async function convertCharacterToPersona(characterId = null) {
-    if (null === characterId) characterId = this_chid;
+    if (null === characterId) characterId = Number(this_chid);
     const avatarUrl = characters[characterId]?.avatar;
     if (!avatarUrl) {

     /** @type {PersonaConnection[]} */
     const connections = power_user.persona_descriptions[avatarId]?.connections;
     const hasCharLock = !!connections?.some(c =>
-        (!selected_group && c.type === 'character' && c.id === characters[this_chid]?.avatar)
+        (!selected_group && c.type === 'character' && c.id === characters[Number(this_chid)]?.avatar)
         || (selected_group && c.type === 'group' && c.id === selected_group));
     return {

  * @returns {string[]} - An array of persona keys that are connected to the given character key
  */
 export function getConnectedPersonas(characterKey = undefined) {
-    characterKey ??= selected_group || characters[this_chid]?.avatar;
+    characterKey ??= selected_group || characters[Number(this_chid)]?.avatar;
     const connectedPersonas = Object.entries(power_user.persona_descriptions)
         .filter(([_, desc]) => desc.connections?.some(conn => conn.type === 'character' && conn.id === characterKey))
         .map(([key, _]) => key);

                 console.log(`Unlocking persona ${personaId} from current character ${name2}`);
                 power_user.persona_descriptions[personaId].connections = connections.filter(c => {
                     if (menu_type == 'group_edit' && c.type == 'group' && c.id == selected_group) return false;
-                    else if (c.type == 'character' && c.id == characters[this_chid]?.avatar) return false;
+                    else if (c.type == 'character' && c.id == characters[Number(this_chid)]?.avatar) return false;
                     return true;
                 });
                 saveSettingsDebounced();

 export function getCurrentConnectionObj() {
     if (selected_group)
         return { type: 'group', id: selected_group };
-    if (characters[this_chid]?.avatar)
+    if (characters[Number(this_chid)]?.avatar)
-        return { type: 'character', id: characters[this_chid]?.avatar };
+        return { type: 'character', id: characters[Number(this_chid)]?.avatar };
     return null;
+}

@@ -1664,7 +1665,7 @@ async function syncUserNameToPersona() {
1664	* Only works if only the first message is present, and not in group mode.	1665	* Only works if only the first message is present, and not in group mode.
1665	*/	1666	*/
1666	export function retriggerFirstMessageOnEmptyChat() {	1667	export function retriggerFirstMessageOnEmptyChat() {
1667	if (this_chid >= 0 && !selected_group && chat.length === 1) {	1668	if (Number(this_chid) >= 0 && !selected_group && chat.length === 1) {
1668	$('#firstmessage_textarea').trigger('input');	1669	$('#firstmessage_textarea').trigger('input');
1669	}	1670	}
1670	}	1671	}

         if (!persona) persona = Object.entries(power_user.personas).find(([_, personaName]) => personaName.toLowerCase() === name.toLowerCase())?.[1];
         if (persona) {
             autoSelectPersona(persona);
-            retriggerFirstMessageOnEmptyChat();
             return '';
         } else if (mode === 'lookup') {
             toastr.warning(`Persona ${name} not found`);

     if (['temp', 'all'].includes(mode)) {
         // Otherwise, set just the name
         setUserName(name); //this prevented quickReply usage
-        retriggerFirstMessageOnEmptyChat();
+    }
     return '';

     $(document).on('click', '#user_avatar_block .avatar-container', function () {
         const imgfile = $(this).attr('data-avatar-id');
         setUserAvatar(imgfile);
-        // force firstMes {{user}} update on persona switch
-        retriggerFirstMessageOnEmptyChat();
     });
     $('#persona_rename_button').on('click', () => renamePersona(user_avatar));

@@ -1979,4 +1975,3 @@ export async function initPersonas() {
1979	eventSource.on(event_types.CHAT_CHANGED, loadPersonaForCurrentChat);	1975	eventSource.on(event_types.CHAT_CHANGED, loadPersonaForCurrentChat);
1980	switchPersonaGridView();	1976	switchPersonaGridView();
1981	}	1977	}
1982