Fix: skip generating thumbnails for APNG Backported from #5113

266f3ade0d42b64fabe0452cc485eb1e1c2e49e9

Cohee <18619528+Cohee1207@users.noreply.github.com>

src/endpoints/image-metadata.js+1 -1 Viewed

  * @param {Buffer} buffer The file buffer.
  * @returns {boolean}
  */
-function isAnimatedApng(buffer) {
+export function isAnimatedApng(buffer) {
     return buffer.subarray(0, 200).includes('acTL');
+}

src/endpoints/thumbnails.js+11 -1 Viewed

 import { imageSize as sizeOf } from 'image-size';
 import { getConfigValue, invalidateFirefoxCache } from '../util.js';
-import { getThumbnailResolution, isAnimatedWebP, thumbnailDimensions as dimensions } from './image-metadata.js';
+import { getThumbnailResolution, isAnimatedWebP, thumbnailDimensions as dimensions, isAnimatedApng } from './image-metadata.js';
 import { ResizeStrategy } from '@jimp/plugin-resize';
 export const publicRouter = express.Router();

@@ -159,6 +159,16 @@ export async function generateThumbnail(directories, type, file, forceGenerate =
159	}	159	}
160	}	160	}
161		161
		162	// For PNG files, check if they are actually APNGs.
		163	if (fileExtension === '.png' && isKnownAnimated !== false) {
		164	const buffer = fs.readFileSync(pathToOriginalFile);
		165	const isAnimated = isAnimatedApng(buffer);
		166	if (isAnimated) {
		167	// The client is expected to handle it.
		168	return { path: null, aspectRatio: null, resolution: null };
		169	}
		170	}
		171
162	if (SKIPPED_EXTENSIONS.has(fileExtension)) {	172	if (SKIPPED_EXTENSIONS.has(fileExtension)) {
163	return { path: null, aspectRatio: null, resolution: null };	173	return { path: null, aspectRatio: null, resolution: null };
164	}	174	}