Add try-catch to rename chat endpoint

363b07ab0bcae1e5a5d62979fa6a4659f72c4b2d

Cohee <18619528+Cohee1207@users.noreply.github.com>

Parents: eced082571d44998f66e8eea6786d816f30eea1b

src/endpoints/chats.js+26 -21 Viewed

@@ -69,7 +69,7 @@ function getBackupFunction(handle) {
69	69	if (!backupFunctions.has(handle)) {
70	70	backupFunctions.set(handle, _.throttle(backupChat, throttleInterval, { leading: true, trailing: true }));
71	71	}
72	72	return backupFunctions.get(handle) \|\| (() => { });
73	73	}
74	74
75	75	/**

 });
 router.post('/rename', validateAvatarUrlMiddleware, async function (request, response) {
 -    if (!request.body || !request.body.original_file || !request.body.renamed_file) {
 +    try {
 -        return response.sendStatus(400);
 +        if (!request.body || !request.body.original_file || !request.body.renamed_file) {
 -    }
 +            return response.sendStatus(400);
 +        }
             const pathToFolder = request.body.is_group
                     ? request.user.directories.groupChats
                     : path.join(request.user.directories.chats, String(request.body.avatar_url).replace('.png', ''));
             const pathToOriginalFile = path.join(pathToFolder, sanitize(request.body.original_file));
             const pathToRenamedFile = path.join(pathToFolder, sanitize(request.body.renamed_file));
             const sanitizedFileName = path.parse(pathToRenamedFile).name;
             console.infodebug('Old chat name', pathToOriginalFile);
             console.infodebug('New chat name', pathToRenamedFile);
++
 +        if (!fs.existsSync(pathToOriginalFile) || fs.existsSync(pathToRenamedFile)) {
 +            console.error('Either Source or Destination files are not available');
 +            return response.status(400).send({ error: true });
 +        }
 -    if (!fs.existsSync(pathToOriginalFile) || fs.existsSync(pathToRenamedFile)) {
 +        fs.copyFileSync(pathToOriginalFile, pathToRenamedFile);
 -        console.error('Either Source or Destination files are not available');
 +        fs.unlinkSync(pathToOriginalFile);
 -        return response.status(400).send({ error: true });
 +        console.info('Successfully renamed chat file.');
 +        return response.send({ ok: true, sanitizedFileName });
 +    } catch (error) {
 +        console.error('Error renaming chat file:', error);
 +        return response.status(500).send({ error: true });
+    }
+-
 -    fs.copyFileSync(pathToOriginalFile, pathToRenamedFile);
 -    fs.unlinkSync(pathToOriginalFile);
 -    console.info('Successfully renamed.');
 -    return response.send({ ok: true, sanitizedFileName });
 });
 router.post('/delete', validateAvatarUrlMiddleware, function (request, response) {

             // Search through title and messages of the chat
             const fragments = query.trim().toLowerCase().split(/\s+/).filter(x => x);
             const text = [path.parse(chatFile.path).name,
                             ...messages.map(message => message?.mes)].join('\n').toLowerCase();
             const hasMatch = fragments.every(fragment => text.includes(fragment));
             if (hasMatch) {