Refactor to not use array

370bd9a3a88efa13604f178689f1ea74eda15821

Cohee <18619528+Cohee1207@users.noreply.github.com>

public/scripts/group-chats.js+8 -8 Viewed

  * @returns {number[]} List of character ids
  */
 function activatePooledOrder(members, lastMessage) {
-    const activatedMembers = [];
+    /** @type {string} */
+    let activatedMember = null;
+    /** @type {string[]} */
     const spokenSinceUser = [];
     for (const message of chat.slice().reverse()) {

     const haveNotSpoken = members.filter(x => !spokenSinceUser.includes(x));
     if (haveNotSpoken.length) {
-        activatedMembers.push(haveNotSpoken[Math.floor(Math.random() * haveNotSpoken.length)]);
+        activatedMember = haveNotSpoken[Math.floor(Math.random() * haveNotSpoken.length)];
+    }
-    if (activatedMembers.length === 0) {
+    if (activatedMember === null) {
         const lastMessageAvatar = members.length > 1 && lastMessage && !lastMessage.is_user && lastMessage.original_avatar;
         const randomPool = lastMessageAvatar ? members.filter(x => x !== lastMessage.original_avatar) : members;
-        activatedMembers.push(randomPool[Math.floor(Math.random() * randomPool.length)]);
+        activatedMember = randomPool[Math.floor(Math.random() * randomPool.length)];
+    }
-    const memberIds = activatedMembers
+    const memberId = characters.findIndex(y => y.avatar === activatedMember);
-        .map((x) => characters.findIndex((y) => y.avatar === x))
+    return memberId !== -1 ? [memberId] : [];
-        .filter((x) => x !== -1);
-    return memberIds;
+}
 function activateNaturalOrder(members, input, lastMessage, allowSelfResponses, isUserInput) {