Add GGUF models and denoise parameter for ComfyUI

5992117904ed9be5af20c2e8582a979a37235cdd

ceruleandeep <deep@cerulean.navy>

4 files changed, +34 -15Ignore whitespace
public/scripts/extensions/stable-diffusion/comfyWorkflowEditor.html+1 -0
@@ -17,6 +17,7 @@
1717 <li data-placeholder="scheduler" class="sd_comfy_workflow_editor_not_found">"%scheduler%"</li>
1818 <li data-placeholder="steps" class="sd_comfy_workflow_editor_not_found">"%steps%"</li>
1919 <li data-placeholder="scale" class="sd_comfy_workflow_editor_not_found">"%scale%"</li>
20+ <li data-placeholder="denoise" class="sd_comfy_workflow_editor_not_found">"%denoise%"</li>
2021 <li data-placeholder="clip_skip" class="sd_comfy_workflow_editor_not_found">"%clip_skip%"</li>
2122 <li data-placeholder="width" class="sd_comfy_workflow_editor_not_found">"%width%"</li>
2223 <li data-placeholder="height" class="sd_comfy_workflow_editor_not_found">"%height%"</li>
public/scripts/extensions/stable-diffusion/index.js+4 -0
@@ -3269,6 +3269,10 @@ async function generateComfyImage(prompt, negativePrompt, signal) {
32693269
32703270 const seed = extension_settings.sd.seed >= 0 ? extension_settings.sd.seed : Math.round(Math.random() * Number.MAX_SAFE_INTEGER);
32713271 workflow = workflow.replaceAll('"%seed%"', JSON.stringify(seed));
3272+
3273+ const denoising_strength = extension_settings.sd.denoising_strength === undefined ? 1.0 : extension_settings.sd.denoising_strength;
3274+ workflow = workflow.replaceAll('"%denoise%"', JSON.stringify(denoising_strength));
3275+
32723276 placeholders.forEach(ph => {
32733277 workflow = workflow.replaceAll(`"%${ph}%"`, JSON.stringify(extension_settings.sd[ph]));
32743278 });
public/scripts/extensions/stable-diffusion/settings.html+1 -1
@@ -319,7 +319,7 @@
319319 <input class="neo-range-input" type="number" id="sd_hr_scale_value" data-for="sd_hr_scale" min="{{hr_scale_min}}" max="{{hr_scale_max}}" step="{{hr_scale_step}}" value="{{hr_scale}}" >
320320 </div>
321321
322322 <div class="alignitemscenter flex-container flexFlowColumn flexGrow flexShrink gap0 flexBasis48p" data-sd-source="auto,vlad,comfy">
323323 <small>
324324 <span data-i18n="Denoising strength">Denoising strength</span>
325325 </small>
src/endpoints/stable-diffusion.js+28 -14
@@ -7,7 +7,7 @@ import sanitize from 'sanitize-filename';
77import { sync as writeFileAtomicSync } from 'write-file-atomic';
88import FormData from 'form-data';
99
1010import { getBasicAuthHeaderdelay, delaygetBasicAuthHeader } from '../util.js';
1111import { jsonParser } from '../express-common.js';
1212import { readSecret, SECRET_KEYS } from './secrets.js';
1313
@@ -19,7 +19,7 @@ import { readSecret, SECRET_KEYS } from './secrets.js';
1919function getComfyWorkflows(directories) {
2020 return fs
2121 .readdirSync(directories.comfyWorkflows)
2222 .filter(file => file[0] !== '.' && file.toLowerCase().endsWith('.json'))
2323 .sort(Intl.Collator().compare);
2424}
2525
@@ -67,8 +67,7 @@ router.post('/upscalers', jsonParser, async (request, response) => {
6767
6868 /** @type {any} */
6969 const data = await result.json();
7070 const names =return data.map(x => x.name);
71- return names;
7271 }
7372
7473 async function getLatentUpscalers() {
@@ -88,8 +87,7 @@ router.post('/upscalers', jsonParser, async (request, response) => {
8887
8988 /** @type {any} */
9089 const data = await result.json();
9190 const names =return data.map(x => x.name);
92- return names;
9391 }
9492
9593 const [upscalers, latentUpscalers] = await Promise.all([getUpscalerModels(), getLatentUpscalers()]);
@@ -241,8 +239,7 @@ router.post('/set-model', jsonParser, async (request, response) => {
241239 'Authorization': getBasicAuthHeader(request.body.auth),
242240 },
243241 });
244242 const data =return await result.json();
245- return data;
246243 }
247244
248245 const url = new URL(request.body.url);
@@ -274,7 +271,7 @@ router.post('/set-model', jsonParser, async (request, response) => {
274271
275272 const progress = progressState['progress'];
276273 const jobCount = progressState['state']['job_count'];
277274 if (progress === 0.0 && jobCount === 0) {
278275 break;
279276 }
280277
@@ -412,8 +409,18 @@ comfy.post('/models', jsonParser, async (request, response) => {
412409 }
413410 /** @type {any} */
414411 const data = await result.json();
415- return response.send(data.CheckpointLoaderSimple.input.required.ckpt_name[0].map(it => ({ value: it, text: it })));
412+
416- } catch (error) {
413+ const ckpts = data.CheckpointLoaderSimple.input.required.ckpt_name[0].map(it => ({ value: it, text: it })) || [];
414+
415+ // load list of GGUF unets from diffusion_models if the loader node is available
416+ const ggufs = data.UnetLoaderGGUF?.input.required.unet_name[0].map(it => ({ value: it, text: `GGUF: ${it}` })) || [];
417+ const models = ckpts.concat(ggufs);
418+
419+ // make the display names of the models somewhat presentable
420+ models.forEach(it => it.text = it.text.replace(/\.[^.]*$/, '').replace(/_/g, ' '));
421+
422+ return response.send(models);
423+ } catch (error) {
417424 console.log(error);
418425 return response.sendStatus(500);
419426 }
@@ -550,7 +557,13 @@ comfy.post('/generate', jsonParser, async (request, response) => {
550557 await delay(100);
551558 }
552559 if (item.status.status_str === 'error') {
553- throw new Error('ComfyUI generation did not succeed.');
560+ // Report node tracebacks if available
561+ const errorMessages = item.status?.messages
562+ ?.filter(it => it[0] === 'execution_error')
563+ .map(it => it[1])
564+ .map(it => `${it.node_type} [${it.node_id}] ${it.exception_type}: ${it.exception_message}`)
565+ .join('\n') || '';
566+ throw new Error(`ComfyUI generation did not succeed.\n\n${errorMessages}`.trim());
554567 }
555568 const imgInfo = Object.keys(item.outputs).map(it => item.outputs[it].images).flat()[0];
556569 const imgUrl = new URL(request.body.url);
@@ -563,8 +576,9 @@ comfy.post('/generate', jsonParser, async (request, response) => {
563576 const imgBuffer = await imgResponse.buffer();
564577 return response.send(imgBuffer.toString('base64'));
565578 } catch (error) {
566579 console.log('ComfyUI error:', error);
567- return response.sendStatus(500);
580+ response.status(500).send(`${error.message}`);
581+ return response;
568582 }
569583});
570584