Fix checkpoint create auto generate (and more) - Fix empty checkpoint name on mes click to auto generate - Change /checkpoint-create to not require name and auto generate - Fix popup input type returning empty string instead of null on empty input field

73c14711e1b80addf23d0cca4d3bcc12a275cd13

Wolfsblvt <wolfsblvt@gmail.com>

public/scripts/bookmarks.js+10 -9 Viewed

     const chatNames = await getExistingChatNames();
     const body = await renderTemplateAsync('createCheckpoint', { isReplace: isReplace });
     let name = forceName ||?? await Popup.show.input('Create Checkpoint', body);
 -    if (name === null) {
 +    // Special handling for confirmed empty input (=> auto-generate name)
 -        return null;
 +    if (name === '') {
 -    }
 -    else if (name === '') {
         for (let i = chatNames.length; i < 1000; i++) {
             name = bookmarkNameToken + i;
             if (!chatNames.includes(name)) {

@@ -73,6 +71,9 @@ async function getBookmarkName({ isReplace = false, forceName = null } = {}) {
73	71	}
74	72	}
75	73	}
	74	+ if (!name) {
	75	+ return null;
	76	+ }
76	77
77	78	return `${name} - ${humanizedDateTime()}`;
78	79	}

             const mesId = Number(args.mesId ?? getLastMessageId());
             if (!validateMessageId(mesId, 'Create Checkpoint')) return '';
             if (!text || typeof text !== 'string') {
                 toastr.warning('Checkpoint name must be provideda string or empty', 'Create Checkpoint');
                 return '';
+            }

             SlashCommandArgument.fromProps({
                 description: 'Checkpoint name',
                 typeList: [ARGUMENT_TYPE.STRING],
 -                isRequired: true,
             }),
         ],
         helpString: `
         <div>
             Create a new checkpoint for the selected message with the provided name. If no message id is provided, will use the last message.<br />
 +            Leave the checkpoint name empty to auto-generate one.
         </div>
         <div>
             A created checkpoint will be permanently linked with the message.<br />

public/scripts/popup.js+3 -0 Viewed

         const content = PopupUtils.BuildTextWithHeader(header, text);
         const popup = new Popup(content, POPUP_TYPE.INPUT, defaultValue, popupOptions);
         const value = await popup.show();
 +        // Return values: If empty string, we explicitly handle that as returning that empty string as "success" provided.
 +        // Otherwise, all non-truthy values (false, null, undefined) are treated as "cancel" and return null.
 +        if (value === '') return '';
         return value ? String(value) : null;
     },