Implement move extensions

83965fb611b84e769c62c8428366941b45cda218

Cohee <18619528+Cohee1207@users.noreply.github.com>

Parents: c33649753b7ab730712fac522b432c0749fbb728

public/scripts/extensions.js+58 -8 Viewed

 function updateStatus(success) {
     connectedToApi = success;
     const _text = success ? 't`Connected to API'` : 't`Could not connect to API'`;
     const _class = success ? 'success' : 'failure';
     $('#extensions_status').text(_text);
     $('#extensions_status').attr('class', _class);

+                }
                 if (stateChanged) {
                     waitingForSave = true;
                     const toast = toastr.info('t`The page will be reloaded shortly...'`, 't`Extensions state changed'`);
                     await saveSettings();
                     toastr.clear(toast);
                     waitingForSave = false;

         popupPromise = popup.show();
         checkForUpdatesManual(abortController.signal).finally(() => htmlLoading.remove());
     } catch (error) {
         toastr.error('t`Error loading extensions. See browser console for details.'`);
         console.error(error);
+    }
     if (popupPromise) {

@@ -817,7 +817,7 @@ async function onDeleteClick() {
817	817	}
818	818
819	819	// use callPopup to create a popup for the user to confirm before delete
820	820	const confirmation = await callGenericPopup(t`Are you sure you want to delete ${extensionName}?`, POPUP_TYPE.CONFIRM, '', {});
821	821	if (confirmation === POPUP_RESULT.AFFIRMATIVE) {
822	822	await deleteExtension(extensionName);
823	823	}

         return;
+    }
 -    toastr.info('Not implemented yet');
 +    const source = getExtensionType(extensionName);
 +    const destination = source === 'global' ? 'local' : 'global';
++
 +    const confirmationHeader = t`Move extension`;
 +    const confirmationText = source == 'global'
 +        ? t`Are you sure you want to move ${extensionName} to your local extensions? This will make it available only for you.`
 +        : t`Are you sure you want to move ${extensionName} to the global extensions? This will make it available for all users.`;
++
 +    const confirmation = await Popup.show.confirm(confirmationHeader, confirmationText);
++
 +    if (!confirmation) {
 +        return;
 +    }
++
 +    $(this).find('i').addClass('fa-spin');
 +    await moveExtension(extensionName, source, destination);
 +}
++
 +/**
 + * Moves an extension via the API.
 + * @param {string} extensionName Extension name
 + * @param {string} source Source type
 + * @param {string} destination Destination type
 + * @returns {Promise<void>}
 + */
 +async function moveExtension(extensionName, source, destination) {
 +    try {
 +        const result = await fetch('/api/extensions/move', {
 +            method: 'POST',
 +            headers: getRequestHeaders(),
 +            body: JSON.stringify({
 +                extensionName,
 +                source,
 +                destination,
 +            }),
 +        });
++
 +        if (!result.ok) {
 +            const text = await result.text();
 +            toastr.error(text || result.statusText, t`Extension move failed`, { timeOut: 5000 });
 +            console.error('Extension move failed', result.status, result.statusText, text);
 +            return;
 +        }
++
 +        toastr.success(t`Extension ${extensionName} moved.`);
 +        await loadExtensionSettings({}, false, false);
 +        await Popup.util.popups.find(popup => popup.content.querySelector('.extensions_info'))?.completeCancelled();
 +        showExtensionsDetails();
 +    } catch (error) {
 +        console.error('Error:', error);
 +    }
+}
 /**

         console.error('Error:', error);
+    }
     toastr.success(t`Extension ${extensionName} deleted`);
     showExtensionsDetails();
     // reload the page to remove the extension from the list
     location.reload();

 export async function installExtension(url, global) {
     console.debug('Extension installation started', url);
     toastr.info('t`Please wait...'`, 't`Installing extension'`);
     const request = await fetch('/api/extensions/install', {
         method: 'POST',

     if (!request.ok) {
         const text = await request.text();
         toastr.warning(text || request.statusText, 't`Extension installation failed'`, { timeOut: 5000 });
         console.error('Extension installation failed', request.status, request.statusText, text);
         return;
+    }

src/endpoints/extensions.js+47 -0 Viewed

         const { url, global } = request.body;
         if (global && !request.user.profile.admin) {
 +            console.warn(`User ${request.user.profile.handle} does not have permission to install global extensions.`);
             return response.status(403).send('Forbidden: No permission to install global extensions.');
+        }

         const { extensionName, global } = request.body;
         if (global && !request.user.profile.admin) {
 +            console.warn(`User ${request.user.profile.handle} does not have permission to update global extensions.`);
             return response.status(403).send('Forbidden: No permission to update global extensions.');
+        }

+    }
 });
 +router.post('/move', jsonParser, async (request, response) => {
 +    try {
 +        const { extensionName, source, destination } = request.body;
++
 +        if (!extensionName || !source || !destination) {
 +            return response.status(400).send('Bad Request. Not all required parameters are provided.');
 +        }
++
 +        if (!request.user.profile.admin) {
 +            console.warn(`User ${request.user.profile.handle} does not have permission to move extensions.`);
 +            return response.status(403).send('Forbidden: No permission to move extensions.');
 +        }
++
 +        const sourceDirectory = source === 'global' ? PUBLIC_DIRECTORIES.globalExtensions : request.user.directories.extensions;
 +        const destinationDirectory = destination === 'global' ? PUBLIC_DIRECTORIES.globalExtensions : request.user.directories.extensions;
 +        const sourcePath = path.join(sourceDirectory, sanitize(extensionName));
 +        const destinationPath = path.join(destinationDirectory, sanitize(extensionName));
++
 +        if (!fs.existsSync(sourcePath) || !fs.statSync(sourcePath).isDirectory()) {
 +            console.error(`Source directory does not exist at ${sourcePath}`);
 +            return response.status(404).send('Source directory does not exist.');
 +        }
++
 +        if (fs.existsSync(destinationPath)) {
 +            console.error(`Destination directory already exists at ${destinationPath}`);
 +            return response.status(409).send('Destination directory already exists.');
 +        }
++
 +        if (source === destination) {
 +            console.error('Source and destination directories are the same');
 +            return response.status(409).send('Source and destination directories are the same.');
 +        }
++
 +        fs.cpSync(sourcePath, destinationPath, { recursive: true, force: true });
 +        fs.rmSync(sourcePath, { recursive: true, force: true });
 +        console.log(`Extension has been moved from ${sourcePath} to ${destinationPath}`);
++
 +        return response.sendStatus(204);
 +    } catch (error) {
 +        console.log('Moving extension failed', error);
 +        return response.status(500).send('Internal Server Error. Try again later.');
 +    }
 +});
++
 /**
  * HTTP POST handler function to get the current git commit hash and branch name for a given extension.
  * It checks whether the repository is up-to-date with the remote, and returns the status along with

         const { extensionName, global } = request.body;
         if (global && !request.user.profile.admin) {
 +            console.warn(`User ${request.user.profile.handle} does not have permission to delete global extensions.`);
             return response.status(403).send('Forbidden: No permission to delete global extensions.');
+        }