Fix path.join to extension

9cff3861b49ee9253b40c2780aa0c20908b7dc32

Cohee <18619528+Cohee1207@users.noreply.github.com>

src/endpoints/extensions.js+5 -5 Viewed

+        }
         const basePath = global ? PUBLIC_DIRECTORIES.globalExtensions : request.user.directories.extensions;
-        const extensionPath = path.join(basePath, extensionName);
+        const extensionPath = path.join(basePath, sanitize(extensionName));
         if (!fs.existsSync(extensionPath)) {
             return response.status(404).send(`Directory does not exist at ${extensionPath}`);

+        }
         const basePath = global ? PUBLIC_DIRECTORIES.globalExtensions : request.user.directories.extensions;
-        const extensionPath = path.join(basePath, extensionName);
+        const extensionPath = path.join(basePath, sanitize(extensionName));
         if (!fs.existsSync(extensionPath)) {
             return response.status(404).send(`Directory does not exist at ${extensionPath}`);

         return response.send(result);
     } catch (error) {
         console.error('Getting branches failed', error);
-        return response.status(500).send('Internal Server Error. Try again later.');
+        return response.status(500).send('Internal Server Error. Check the server logs for more details.');
+    }
 });

+        }
         const basePath = global ? PUBLIC_DIRECTORIES.globalExtensions : request.user.directories.extensions;
-        const extensionPath = path.join(basePath, extensionName);
+        const extensionPath = path.join(basePath, sanitize(extensionName));
         if (!fs.existsSync(extensionPath)) {
             return response.status(404).send(`Directory does not exist at ${extensionPath}`);

         return response.sendStatus(204);
     } catch (error) {
         console.error('Moving extension failed', error);
-        return response.status(500).send('Internal Server Error. Try again later.');
+        return response.status(500).send('Internal Server Error. Check the server logs for more details.');
+    }
 });