Fix default emojis expression setting resetting (#4206) Adjusts conditions to properly enforce mutual exclusivity between fallback expression and default emoji settings - Ensures "[ No fallback ]" option only appears when both settings are inactive - Updates migration logic to ONLY reset default emoji setting when fallback is active Fixes #4205

b1887a0cc262af4c7884bcaa48ab3a3fabe49514

Wolfsblvt <wolfsblvt@gmail.com>

Signed
Parents: 6f5f945eb26e5bd75274ce510b247d617d68aca1
1 files changed, +2 -2Ignore whitespace
public/scripts/extensions/expressions/index.js+2 -2
@@ -1331,7 +1331,7 @@ async function renderFallbackExpressionPicker() {
13311331 defaultPicker.empty();
13321332
13331333
13341334 addOption(OPTION_NO_FALLBACK, '[ No fallback ]', !extension_settings.expressions.fallback_expression && !extension_settings.expressions.showDefault);
13351335 addOption(OPTION_EMOJI_FALLBACK, '[ Default emojis ]', !!extension_settings.expressions.showDefault);
13361336
13371337 for (const expression of expressions) {
@@ -2116,7 +2116,7 @@ function migrateSettings() {
21162116 saveSettingsDebounced();
21172117 }
21182118
21192119 if (extension_settings.expressions.showDefault && extension_settings.expressions.fallback_expression !== undefined) {
21202120 extension_settings.expressions.showDefault = false;
21212121 saveSettingsDebounced();
21222122 }