Refactor context change checks during chat summarization

b6af55134abeccff74bae19b9b7741ceaa0eb89f

Cohee <18619528+Cohee1207@users.noreply.github.com>

public/scripts/extensions/memory/index.js+20 -18 Viewed

     return -1;
+}
 +/**
 + * Check if something is changed during the summarization process.
 + * @param {{ groupId: any; chatId: any; characterId: any; }} context
 + * @returns {boolean} True if the context has changed and the summary should be discarded
 + */
 +function isContextChanged(context) {
 +    const newContext = getContext();
 +    if (newContext.groupId !== context.groupId
 +        || newContext.chatId !== context.chatId
 +        || (!newContext.groupId && (newContext.characterId !== context.characterId))) {
 +        console.log('Context changed, summary discarded');
 +        return true;
 +    }
++
 +    return false;
 +}
++
 function onChatChanged() {
     const context = getContext();
     const latestMemory = getLatestMemoryFromChat(context.chat);

     try {
         inApiCall = true;
         const summary = await generateWebLlmChatPrompt(messages, params);
 -        const newContext = getContext();
         if (!summary) {
             console.warn('Empty summary received');

@@ -634,10 +650,7 @@ async function summarizeChatWebLLM(context, force) {
634	650	}
635	651
636	652	// something changed during summarization request
637		- if (newContext.groupId !== context.groupId \|\|
	653	+ if (isContextChanged(context)) {
638		- newContext.chatId !== context.chatId \|\|
639		- (!newContext.groupId && (newContext.characterId !== context.characterId))) {
640		- console.log('Context changed, summary discarded');
641	654	return;
642	655	}
643	656

         return;
+    }
 -    const newContext = getContext();
 +    if (isContextChanged(context)) {
+-
 -    // something changed during summarization request
 -    if (newContext.groupId !== context.groupId
 -        || newContext.chatId !== context.chatId
 -        || (!newContext.groupId && (newContext.characterId !== context.characterId))) {
 -        console.log('Context changed, summary discarded');
         return;
+    }

     try {
         inApiCall = true;
         const summary = await callExtrasSummarizeAPI(resultingString);
 -        const newContext = getContext();
         if (!summary) {
             console.warn('Empty summary received');
             return;
+        }
 -        // something changed during summarization request
 +        if (isContextChanged(context)) {
 -        if (newContext.groupId !== context.groupId
 -            || newContext.chatId !== context.chatId
 -            || (!newContext.groupId && (newContext.characterId !== context.characterId))) {
 -            console.log('Context changed, summary discarded');
             return;
+        }