fix: enhance URL validation for Z.AI image generation (#5482) * fix: enhance URL validation for Z.AI image generation and handle potential delays Fixes #5480 * fix: retry 404 in a loop * fix: handle Z.AI image and video unavailability with appropriate warnings and responses

b8f2b1cfa66ae9dee462d329b8c114f747bc21f6

Cohee <18619528+Cohee1207@users.noreply.github.com>

Signed

Parents: b44b12b52734568cae63080f3d57be6a0f4fe28c

src/endpoints/stable-diffusion.js+23 -3 Viewed

         const data = await generateResponse.json();
         console.debug('Z.AI image response:', data);
         const urlurlString = String(data?.data?.[0]?.url ?? '');
         if (!urlurlString || !isValidUrl(url) || !new URL(url).hostname.endsWith('.z.ai'urlString)) {
             console.warn('Z.AI returned an invalid image URL.');
             return response.sendStatus(500);
+        }
 +        const url = new URL(urlString);
 +        if (!url.hostname.endsWith('.z.ai') && !url.hostname.endsWith('.ufileos.com')) {
 +            console.warn('Z.AI returned a URL with an unrecognized hostname.');
 +            return response.sendStatus(500);
 +        }
++
 +        for (let attempt = 0; attempt < 5; attempt++) {
             const imageResponse = await fetch(url);
             if (!imageResponse.ok) {
 +                // Sometimes the URL is valid but the image isn't immediately available
 +                if (imageResponse.status === 404) {
 +                    console.info('Z.AI image not found yet, retrying...', { attempt: attempt + 1 });
 +                    await delay(1000);
 +                    continue;
 +                }
++
                 console.warn('Z.AI image fetch returned an error. Status:', imageResponse.status, imageResponse.statusText);
                 return response.sendStatus(500);
+            }
             const buffer = await imageResponse.arrayBuffer();
             const image = Buffer.from(buffer).toString('base64');
                     const format = path.extname(url.pathname).substring(1).toLowerCase() || 'png';
             return response.send({ image, format });
 +        }
++
 +        console.warn('Z.AI image was not available after multiple attempts.');
 +        return response.sendStatus(500);
     } catch (error) {
         console.error(error);
         return response.sendStatus(500);

@@ -2024,6 +2042,8 @@ zai.post('/generate-video', async (request, response) => {
2024	2042	return response.send({ format: 'mp4', video: Buffer.from(contentBuffer).toString('base64') });
2025	2043	}
2026	2044	}
	2045	+ console.warn('Z.AI video was not available after multiple attempts.');
	2046	+ return response.sendStatus(500);
2027	2047	} catch (error) {
2028	2048	console.error(error);
2029	2049	return response.sendStatus(500);