fix(middleware): skip New connection message and `access.log` writes for localhost

bfc609c2a8fa0743e72d49278e72ec48cbc416d0

KevinSun <paver.mails+github@gmail.com>

Signed
Parents: db500188d87ab9fe376b7bb7aaff7d0b5baea267
2 files changed, +4 -3Showing whitespace changes
server.js+1 -1
@@ -344,7 +344,7 @@ app.use(CORS);
344if (listen && basicAuthMode) app.use(basicAuthMiddleware);344if (listen && basicAuthMode) app.use(basicAuthMiddleware);
345345
346app.use(whitelistMiddleware(enableWhitelist));346app.use(whitelistMiddleware(enableWhitelist));
347app.use(accessLoggerMiddleware());347app.use(accessLoggerMiddleware(listen));
348348
349if (enableCorsProxy) {349if (enableCorsProxy) {
350 app.use(bodyParser.json({350 app.use(bodyParser.json({
src/middleware/accessLogger.js+3 -2
@@ -28,14 +28,15 @@ export function migrateAccessLog() {
2828
29/**29/**
30 * Creates middleware for logging access and new connections30 * Creates middleware for logging access and new connections
31 * @param {boolean} listen If listen mode is enabled via config or command line
31 * @returns {import('express').RequestHandler}32 * @returns {import('express').RequestHandler}
32 */33 */
33export default function accessLoggerMiddleware() {34export default function accessLoggerMiddleware(listen) {
34 return function (req, res, next) {35 return function (req, res, next) {
35 const clientIp = getRealIpFromHeader(req);36 const clientIp = getRealIpFromHeader(req);
36 const userAgent = req.headers['user-agent'];37 const userAgent = req.headers['user-agent'];
3738
38 if (!knownIPs.has(clientIp)) {39 if (listen && !knownIPs.has(clientIp)) {
39 // Log new connection40 // Log new connection
40 console.info(color.yellow(`New connection from ${clientIp}; User Agent: ${userAgent}\n`));41 console.info(color.yellow(`New connection from ${clientIp}; User Agent: ${userAgent}\n`));
41 knownIPs.add(clientIp);42 knownIPs.add(clientIp);