Remove open bogus folder tags that don't have any entities assigned (#5225) Fixes #5222

d8f39269b96d482cd3671de9a4d66ef412c8bb39

Cohee <18619528+Cohee1207@users.noreply.github.com>

Signed

public/scripts/tags.js+5 -2 Viewed

 function removeMissingTagFilters() {
     const tagIds = new Set(tags.map(tag => tag.id));
+    const assignedTagIds = new Set(Object.values(tag_map).flat());
+    const openBogusFolderIds = new Set(getOpenBogusFolders().map(tag => tag.id));
+    const isEmptyOpenBogusFolder = (tagId) => openBogusFolderIds.has(tagId) && !assignedTagIds.has(tagId);
     for (const helper of [groupCandidatesFilter, groupMembersFilter, entitiesFilter]) {
         const { selected, excluded } = helper.getFilterData(FILTER_TYPES.TAG);

         if (Array.isArray(selected)) {
             for (let i = selected.length - 1; i >= 0; i--) {
-                if (!tagIds.has(selected[i])) {
+                if (!tagIds.has(selected[i]) || isEmptyOpenBogusFolder(selected[i])) {
                     selected.splice(i, 1);
                     anyRemoved = true;
+                }

         if (Array.isArray(excluded)) {
             for (let i = excluded.length - 1; i >= 0; i--) {
-                if (!tagIds.has(excluded[i])) {
+                if (!tagIds.has(excluded[i]) || isEmptyOpenBogusFolder(excluded[i])) {
                     excluded.splice(i, 1);
                     anyRemoved = true;
+                }