Fix stale Diceroll debug blocks on undiced swipes saveReply reuses the message's extra object in place, so swipes generated without a roll (guided swipes, roll failures, extension off) inherited the previous swipe's roll record and kept showing its debug block. Drop the record when a main-type generation finishes unsteered, hide the block as soon as a swipe/regenerate starts instead of leaving it until the result arrives, and skip rendering while an overswipe's generation is in flight.

da6a5b45329915f4f914fee9105096bc892b6b69

permissionBRICK <40219477+permissionBRICK@users.noreply.github.com>

public/scripts/extensions/diceroll/index.js+36 -9 Viewed

 // Roll data waiting to be stamped onto the message the steered generation produces.
 let pendingStamp = null;
 +// Message id stamped by the current generation. MESSAGE_RECEIVED consumes the pending stamp and
 +// CHARACTER_MESSAGE_RENDERED fires right after for the same message; without this marker the
 +// second event would mistake the freshly stamped message for an unsteered one and wipe it.
 +let stampedMesId = null;
++
 // Whether the main generation being intercepted was started with its own custom prompt
 // (e.g. a swipe/regenerate triggered with an additional instruction). Tracked via
 // GENERATION_STARTED because the interceptor does not receive the generation params.

         return;
+    }
 +    stampedMesId = null;
++
 +    // The message being replaced still shows the previous swipe's debug block; hide it as soon as
 +    // the new generation starts instead of leaving it stuck until the result arrives.
 +    if (type === 'swipe' || type === 'regenerate') {
 +        $(`#chat .mes[mesid="${chat.length - 1}"] .diceroll_debug`).remove();
 +    }
++
     // A guided swipe/response (or any generation carrying its own instruction) takes precedence:
     // no roll, no direction injection — the manual instruction alone steers this generation.
     if (hasManualSteering(s)) {

 /**
  * Copies the roll that steered a finished generation onto the produced message, so the debug view
  * stays correct per message and survives reloads. When a main-type generation finishes WITHOUT a
 + * roll (extension disabled, roll failed, or a manual instruction steered it), the roll record
 + * inherited in place from the previous swipe's extra is dropped instead.
  * @param {number} chatId Message index
 + * @param {string} type Generation type the message event was emitted with
  */
 function stampMessage(chatId, type) {
 -    if (!pendingStamp) {
 -        return;
 -    }
     const message = chat[chatId];
     if (!message || message.is_user || message.is_system) {
         return;
+    }
 +    if (pendingStamp) {
         message.extra = message.extra || {};
         message.extra.diceroll = structuredClone(pendingStamp);
         pendingStamp = null;
 +        stampedMesId = chatId;
         saveChatDebounced();
 +    } else if (STEERED_TYPES.has(type) && stampedMesId !== chatId && message.extra?.diceroll) {
 +        delete message.extra.diceroll;
 +        saveChatDebounced();
 +    }
+}
 function renderDebugForMessage(chatId) {

+    }
     mesElement.find('.diceroll_debug').remove();
     const datamessage = chat[chatId]?.extra?.diceroll;
 +    const data = message?.extra?.diceroll;
     if (!getSettings().debugDisplay || !data || !Array.isArray(data.options)) {
         return;
+    }
 +    // An overswipe points swipe_id one past the existing swipes while its generation is running;
 +    // the roll record on the message still belongs to the previous swipe then, so show nothing.
 +    if (typeof message.swipe_id === 'number' && Array.isArray(message.swipes) && message.swipe_id >= message.swipes.length) {
 +        return;
 +    }
++
     const chosen = data.options[data.chosenIndex];
     const details = $('<details class="diceroll_debug"></details>');
     const rollInfo = Number.isFinite(data.roll) ? `, roll ${data.roll.toFixed(1)}/${formatProbability(data.total)}` : '';

+        }
     });
     eventSource.on(event_types.MESSAGE_RECEIVED, (chatId, type) => stampMessage(chatId, type));
     eventSource.on(event_types.CHARACTER_MESSAGE_RENDERED, (chatId, type) => {
         stampMessage(chatId, type);
         renderDebugForMessage(chatId);
     });
     eventSource.on(event_types.MESSAGE_SWIPED, (chatId) => renderDebugForMessage(chatId));
     eventSource.on(event_types.CHAT_CHANGED, () => {
         pendingStamp = null;
 +        stampedMesId = null;
         clearDirectionInjection();
         renderAllDebug();
     });