Ensure unique selectors for loaded extension files

f869b26664516c6a67068c69d3a765c3c5c817b2

Cohee <18619528+Cohee1207@users.noreply.github.com>

public/scripts/extensions.js+7 -5 Viewed

 import { showLoader } from './loader.js';
 import { POPUP_RESULT, POPUP_TYPE, Popup, callGenericPopup } from './popup.js';
 import { renderTemplate, renderTemplateAsync } from './templates.js';
 import { delay, isSubsetOf, sanitizeSelector, setValueByPath } from './utils.js';
 import { getContext } from './st-context.js';
 import { isAdmin } from './user.js';
 import { t } from './i18n.js';

     return new Promise((resolve, reject) => {
         const url = `/scripts/extensions/${name}/${manifest.css}`;
 +        const id = sanitizeSelector(`${name}-css`);
         if ($(`link[id="${nameid}"]`).length === 0) {
             const link = document.createElement('link');
             link.id = nameid;
             link.rel = 'stylesheet';
             link.type = 'text/css';
             link.href = url;

     return new Promise((resolve, reject) => {
         const url = `/scripts/extensions/${name}/${manifest.js}`;
 +        const id = sanitizeSelector(`${name}-js`);
         let ready = false;
         if ($(`script[id="${nameid}"]`).length === 0) {
             const script = document.createElement('script');
             script.id = nameid;
             script.type = 'module';
             script.src = url;
             script.async = true;

public/scripts/utils.js+10 -0 Viewed

     return String(str).replace(/&/g, '&amp;').replace(/</g, '&lt;').replace(/>/g, '&gt;').replace(/"/g, '&quot;');
+}
 +/**
 + * Make string safe for use as a CSS selector.
 + * @param {string} str String to sanitize
 + * @param {string} replacement Replacement for invalid characters
 + * @returns {string} Sanitized string
 + */
 +export function sanitizeSelector(str, replacement = '_') {
 +    return String(str).replace(/[^a-z0-9_-]/ig, replacement);
 +}
++
 export function isValidUrl(value) {
     try {
         new URL(value);