Fix type errors in BulkEditOverlay

02b137c8e258dab4f199253b8e33d610b0122d30

Cohee <18619528+Cohee1207@users.noreply.github.com>

public/scripts/BulkEditOverlay.js+9 -6 Viewed

      * @param {number} characterId
      * @returns {Promise<void>}
      */
-    static persona = async (characterId) => await convertCharacterToPersona(characterId);
+    static persona = async (characterId) => void(await convertCharacterToPersona(characterId));
     /**
      * Delete one or more characters,

@@ -342,7 +342,7 @@ class BulkTagPopupHandler {
342		342
343	for (const characterId of this.characterIds) {	343	for (const characterId of this.characterIds) {
344	for (const tag of mutualTags) {	344	for (const tag of mutualTags) {
345	removeTagFromMap(tag.id, characterId);	345	removeTagFromMap(tag.id, characterId.toString());
346	}	346	}
347	}	347	}
348		348

  * Implement a SingletonPattern, allowing access to the group overlay instance
  * from everywhere via (new CharacterGroupOverlay())
+ *
- * @type BulkEditOverlay
+ * @type {Readonly<BulkEditOverlay>}
  */
 let bulkEditOverlayInstance = null;

@@ -590,7 +590,8 @@ class BulkEditOverlay {
590	this.selectState();	590	this.selectState();
591	} else if (this.state === BulkEditOverlayState.select) {	591	} else if (this.state === BulkEditOverlayState.select) {
592	this.#contextMenuOpen = true;	592	this.#contextMenuOpen = true;
593	CharacterContextMenu.show(...this.#getContextMenuPosition(event));	593	const [x, y] = this.#getContextMenuPosition(event);
		594	CharacterContextMenu.show(x, y);
594	}	595	}
595	}	596	}
596		597

         const characterId = Number(character.getAttribute('data-chid'));
         const select = !this.selectedCharacters.includes(characterId);
-        const legacyBulkEditCheckbox = character.querySelector('.' + BulkEditOverlay.legacySelectedClass);
+        const legacyBulkEditCheckbox = /** @type {HTMLInputElement} */ (character.querySelector('.' + BulkEditOverlay.legacySelectedClass));
         if (select) {
             character.classList.add(BulkEditOverlay.selectedClass);

     handleContextMenuShow = (event) => {
         event.preventDefault();
-        CharacterContextMenu.show(...this.#getContextMenuPosition(event));
+        const [x,y] = this.#getContextMenuPosition(event);
+        CharacterContextMenu.show(x, y);
         this.#contextMenuOpen = true;
     };

         let contextMenu = document.getElementById(BulkEditOverlay.contextMenuId);
         if (false === contextMenu.contains(event.target)) {
             CharacterContextMenu.hide();
+            this.#contextMenuOpen = false;
+        }
     };