Replace Google Translate library (#4884)

10a2f0f7406035ca064eecc2e85f52a707ae770b

Cohee <18619528+Cohee1207@users.noreply.github.com>

Signed

package-lock.json+0 -7 Viewed

                 "express": "^4.21.0",
                 "form-data": "^4.0.4",
                 "fuse.js": "^7.1.0",
-                "google-translate-api-browser": "^3.0.1",
                 "google-translate-api-x": "^10.7.2",
                 "handlebars": "^4.7.8",
                 "helmet": "^8.1.0",

                 "url": "https://github.com/sponsors/sindresorhus"
+            }
         },
-        "node_modules/google-translate-api-browser": {
-            "version": "3.0.1",
-            "resolved": "https://registry.npmjs.org/google-translate-api-browser/-/google-translate-api-browser-3.0.1.tgz",
-            "integrity": "sha512-KTLodkyGBWMK9IW6QIeJ2zCuju4Z0CLpbkADKo+yLhbSTD4l+CXXpQ/xaynGVAzeBezzJG6qn8MLeqOq3SmW0A==",
-            "license": "MIT"
-        },
         "node_modules/google-translate-api-x": {
             "version": "10.7.2",
             "resolved": "https://registry.npmjs.org/google-translate-api-x/-/google-translate-api-x-10.7.2.tgz",

package.json+0 -1 Viewed

         "express": "^4.21.0",
         "form-data": "^4.0.4",
         "fuse.js": "^7.1.0",
-        "google-translate-api-browser": "^3.0.1",
         "google-translate-api-x": "^10.7.2",
         "handlebars": "^4.7.8",
         "helmet": "^8.1.0",

src/endpoints/translate.js+5 -41 Viewed

-import { createRequire } from 'node:module';
 import fetch from 'node-fetch';
 import express from 'express';
 import { translate as bingTranslate } from 'bing-translate-api';
-import iconv from 'iconv-lite';
 import urlJoin from 'url-join';
+import { Translator } from 'google-translate-api-x';
 import { readSecret, SECRET_KEYS } from './secrets.js';
 import { getConfigValue, uuidv4 } from '../util.js';

 export const router = express.Router();
-/**
- * Get the Google Translate API client.
- * @returns {import('google-translate-api-browser')} Google Translate API client
- */
-function getGoogleTranslateClient() {
-    const require = createRequire(import.meta.url);
-    const googleTranslateApi = require('google-translate-api-browser');
-    return googleTranslateApi;
-}
-/**
- * Tries to decode an ArrayBuffer to a string using iconv-lite for UTF-8.
- * @param {ArrayBuffer} buffer ArrayBuffer
- * @returns {string} Decoded string
- */
-function decodeBuffer(buffer) {
-    try {
-        return iconv.decode(Buffer.from(buffer), 'utf-8');
-    } catch (error) {
-        console.error('Failed to decode buffer:', error);
-        return Buffer.from(buffer).toString('utf-8');
-    }
-}
 router.post('/libre', async (request, response) => {
     try {
         const key = readSecret(request.user.directories, SECRET_KEYS.LIBRE);

 router.post('/google', async (request, response) => {
     try {
-        const text = request.body.text;
+        const text = String(request.body.text ?? '');
-        const lang = request.body.lang;
+        const lang = String(request.body.lang ?? '');
         if (!text || !lang) {
             return response.sendStatus(400);

         console.debug('Input text: ' + text);
-        const { generateRequestUrl, normaliseResponse } = getGoogleTranslateClient();
+        const translator = new Translator({ to: lang });
-        const requestUrl = generateRequestUrl(text, { to: lang });
+        const translatedText = await translator.translate(text).then(result => result.text);
-        const result = await fetch(requestUrl);
-        if (!result.ok) {
-            console.warn('Google Translate error: ', result.statusText);
-            return response.sendStatus(500);
-        }
-        const buffer = await result.arrayBuffer();
-        const translateResponse = normaliseResponse(JSON.parse(decodeBuffer(buffer)));
-        const translatedText = translateResponse.text;
         response.setHeader('Content-Type', 'text/plain; charset=utf-8');
         console.debug('Translated text: ' + translatedText);