Add rename buttons for ComfyUI workflows and style presets (#5124) * Initial plan * Add rename buttons for ComfyUI workflows and style presets Co-authored-by: Cohee1207 <18619528+Cohee1207@users.noreply.github.com> * Address review feedback: pencil icon, filename validation, 204 status, error prefix, frontend duplicate check, re-render styles select Co-authored-by: Cohee1207 <18619528+Cohee1207@users.noreply.github.com> * fix: ensure existing workflow check only considers HTMLOptionElement instances --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Cohee1207 <18619528+Cohee1207@users.noreply.github.com>

23ba3e5bb2e7aad59d0912b2b026a14052936f1b

Copilot <198982749+Copilot@users.noreply.github.com>

Signed

public/scripts/extensions/stable-diffusion/index.js+96 -0 Viewed

     saveSettingsDebounced();
+}
+async function onRenameStyleClick() {
+    const selectedStyle = extension_settings.sd.style;
+    const styleObject = extension_settings.sd.styles.find(x => x.name === selectedStyle);
+    if (!styleObject) {
+        return;
+    }
+    const newName = await callGenericPopup(t`Enter new style name:`, POPUP_TYPE.INPUT, selectedStyle);
+    if (!newName) {
+        return;
+    }
+    const name = String(newName).trim();
+    if (name === selectedStyle) {
+        return;
+    }
+    const existingStyle = extension_settings.sd.styles.find(x => x.name === name);
+    if (existingStyle) {
+        toastr.error(t`A style with that name already exists`);
+        return;
+    }
+    styleObject.name = name;
+    extension_settings.sd.style = name;
+    $('#sd_style').empty();
+    for (const style of extension_settings.sd.styles) {
+        const option = document.createElement('option');
+        option.value = style.name;
+        option.text = style.name;
+        option.selected = style.name === extension_settings.sd.style;
+        $('#sd_style').append(option);
+    }
+    saveSettingsDebounced();
+}
 /**
  * Modifies prompt based on user inputs.
  * @param {string} prompt Prompt to refine

     onComfyWorkflowChange();
+}
+async function onComfyRenameWorkflowClick() {
+    const oldName = extension_settings.sd.comfy_workflow;
+    if (!oldName) {
+        return;
+    }
+    let newName = await callGenericPopup(t`Enter new workflow name:`, POPUP_TYPE.INPUT, oldName);
+    if (!newName) {
+        return;
+    }
+    newName = String(newName).trim();
+    if (!newName.toLowerCase().endsWith('.json')) {
+        newName += '.json';
+    }
+    if (newName === oldName) {
+        return;
+    }
+    const existingWorkflow = Array
+        .from(document.querySelectorAll('#sd_comfy_workflow option'))
+        .find(opt => opt instanceof HTMLOptionElement && opt.value === newName);
+    if (existingWorkflow) {
+        toastr.warning(t`A workflow with that name already exists`);
+        return;
+    }
+    const response = await fetch('/api/sd/comfy/rename-workflow', {
+        method: 'POST',
+        headers: getRequestHeaders(),
+        body: JSON.stringify({
+            old_name: oldName,
+            new_name: newName,
+        }),
+    });
+    if (!response.ok) {
+        const text = await response.text();
+        toastr.error(t`Failed to rename workflow.\n\n${text}`);
+        return;
+    }
+    extension_settings.sd.comfy_workflow = newName;
+    saveSettingsDebounced();
+    await loadComfyWorkflows();
+}
 /**
  * Sends a chat message with the generated image.
  * @param {string} prompt Prompt used for the image generation

     $('#sd_comfy_workflow').on('change', onComfyWorkflowChange);
     $('#sd_comfy_open_workflow_editor').on('click', onComfyOpenWorkflowEditorClick);
     $('#sd_comfy_new_workflow').on('click', onComfyNewWorkflowClick);
+    $('#sd_comfy_rename_workflow').on('click', onComfyRenameWorkflowClick);
     $('#sd_comfy_delete_workflow').on('click', onComfyDeleteWorkflowClick);
     $('#sd_style').on('change', onStyleSelect);
     $('#sd_save_style').on('click', onSaveStyleClick);
+    $('#sd_rename_style').on('click', onRenameStyleClick);
     $('#sd_delete_style').on('click', onDeleteStyleClick);
     $('#sd_character_prompt_block').hide();
     $('#sd_interactive_mode').on('input', onInteractiveModeInput);

public/scripts/extensions/stable-diffusion/settings.html+6 -0 Viewed

                     <div id="sd_comfy_new_workflow" class="menu_button menu_button_icon" data-i18n="[title]Create new workflow" title="Create new workflow">
                         <i class="fa-solid fa-plus"></i>
                     </div>
+                    <div id="sd_comfy_rename_workflow" class="menu_button menu_button_icon" data-i18n="[title]Rename workflow" title="Rename workflow">
+                        <i class="fa-solid fa-pencil"></i>
+                    </div>
                     <div id="sd_comfy_delete_workflow" class="menu_button menu_button_icon" data-i18n="[title]Delete workflow" title="Delete workflow">
                         <i class="fa-solid fa-trash-can"></i>
                     </div>

                 <div id="sd_save_style" data-i18n="[title]Save style" title="Save style" class="menu_button">
                     <i class="fa-solid fa-save"></i>
                 </div>
+                <div id="sd_rename_style" data-i18n="[title]Rename style" title="Rename style" class="menu_button">
+                    <i class="fa-solid fa-pencil"></i>
+                </div>
                 <div id="sd_delete_style" data-i18n="[title]Delete style" title="Delete style" class="menu_button">
                     <i class="fa-solid fa-trash-can"></i>
                 </div>

src/endpoints/stable-diffusion.js+29 -0 Viewed

 import { delay, getBasicAuthHeader, isValidUrl, tryParse } from '../util.js';
 import { readSecret, SECRET_KEYS } from './secrets.js';
+import { getFileNameValidationFunction } from '../middleware/validateFileName.js';
 import { AIMLAPI_HEADERS } from '../constants.js';
 /**

+    }
 });
+comfy.post('/rename-workflow', getFileNameValidationFunction('old_name'), getFileNameValidationFunction('new_name'), async (request, response) => {
+    try {
+        const oldName = sanitize(String(request.body.old_name));
+        const newName = sanitize(String(request.body.new_name));
+        if (path.extname(oldName).toLowerCase() !== '.json' || path.extname(newName).toLowerCase() !== '.json') {
+            return response.status(400).send('Only JSON workflow files are allowed');
+        }
+        const oldPath = path.join(request.user.directories.comfyWorkflows, oldName);
+        const newPath = path.join(request.user.directories.comfyWorkflows, newName);
+        if (!fs.existsSync(oldPath)) {
+            return response.status(404).send('Workflow not found');
+        }
+        if (fs.existsSync(newPath)) {
+            return response.status(409).send('A workflow with that name already exists');
+        }
+        fs.renameSync(oldPath, newPath);
+        return response.sendStatus(204);
+    } catch (error) {
+        console.error('ComfyUI workflow rename failed', error);
+        return response.sendStatus(500);
+    }
+});
 comfy.post('/generate', async (request, response) => {
     try {
         let item;