Fix async file deletion bugs in assets endpoint (#5363) The delete handler had a missing `return` before `sendStatus(400)`, causing execution to fall through to `sendStatus(200)`, a double-send that triggers ERR_HTTP_HEADERS_SENT, which the catch block then compounds by attempting a third `sendStatus(500)`. Both the delete and download handlers used callback-based `fs.unlink()` without awaiting completion. In the download handler, this caused a race with `createWriteStream({ flags: 'wx' })` (which fails if the file still exists). In both handlers, `throw err` inside the callback was an unhandled exception that could never be caught by the outer try/catch. Replace callback-based `fs.unlink()` with `await fs.promises.unlink()` and add missing `return` statements to prevent response cascades.

271c1e22ca3299c21b8d8e7988a22ffd6c1d1a9b

Tony Gies <tgies@tgies.net>

Signed

src/endpoints/assets.js+8 -14 Viewed

         const destination = path.resolve(temp_path);
         // Delete if previous download failed
         if (fs.existsSync(temp_path)) {
-            fs.unlink(temp_path, (err) => {
+            await fs.promises.unlink(temp_path);
-                if (err) throw err;
-            });
+        }
         const fileStream = fs.createWriteStream(destination, { flags: 'wx' });
         // @ts-ignore

     console.info('Request received to delete', category, file_path);
     try {
-        // Delete if previous download failed
+        if (!fs.existsSync(file_path)) {
-        if (fs.existsSync(file_path)) {
-            fs.unlink(file_path, (err) => {
-                if (err) throw err;
-            });
-            console.info('Asset deleted.');
-        } else {
             console.error('Asset not found.');
-            response.sendStatus(400);
+            return response.sendStatus(400);
+        }
-        // Move into asset place
-        response.sendStatus(200);
+        await fs.promises.unlink(file_path);
+        console.info('Asset deleted.');
+        return response.sendStatus(200);
     } catch (error) {
         console.error(error);
-        response.sendStatus(500);
+        return response.sendStatus(500);
+    }
 });