Extensions: Check if directory is a repo root before updating/getting status

2b7c0a3d377ee957a7bddffea46514d6c2e293c7

Cohee <18619528+Cohee1207@users.noreply.github.com>

src/endpoints/extensions.js+11 -4 Viewed

 import express from 'express';
 import sanitize from 'sanitize-filename';
-import { default as simpleGit } from 'simple-git';
+import { CheckRepoActions, default as simpleGit } from 'simple-git';
 import { PUBLIC_DIRECTORIES } from '../constants.js';

         const { isUpToDate, remoteUrl } = await checkIfRepoIsUpToDate(extensionPath);
         const git = simpleGit({ baseDir: extensionPath });
+        const isRepo = await git.checkIsRepo(CheckRepoActions.IS_REPO_ROOT);
+        if (!isRepo) {
+            throw new Error(`Directory is not a Git repository at ${extensionPath}`);
+        }
         const currentBranch = await git.branch();
         if (!isUpToDate) {
             await git.pull('origin', currentBranch.current);

         const shortCommitHash = fullCommitHash.slice(0, 7);
         return response.send({ shortCommitHash, extensionPath, isUpToDate, remoteUrl });
     } catch (error) {
-        console.error('Updating custom content failed', error);
+        console.error('Updating extension failed', error);
-        return response.status(500).send(`Server Error: ${error.message}`);
+        return response.status(500).send('Internal Server Error. Check the server logs for more details.');
+    }
 });

         const git = simpleGit({ baseDir: extensionPath });
         let currentCommitHash;
         try {
+            const isRepo = await git.checkIsRepo(CheckRepoActions.IS_REPO_ROOT);
+            if (!isRepo) {
+                throw new Error(`Directory is not a Git repository at ${extensionPath}`);
+            }
             currentCommitHash = await git.revparse(['HEAD']);
         } catch (error) {
             // it is not a git repo, or has no commits yet, or is a bare repo