Replace details view toggle with a button

38751d4fe20b0aa1ef3a3e0ff2952569dd5da220

Cohee <18619528+Cohee1207@users.noreply.github.com>

Parents: 7952b5f2c9a255d0f18a145a653a425d2e3ab13d

public/script.js+1 -1 Viewed

     });
     $('#main_api').change(function () {
-        cancelStatusCheck("Canceled because main api changed");
+        cancelStatusCheck('Canceled because main api changed');
         changeMainAPI();
         saveSettingsDebounced();
     });

public/scripts/extensions/connection-manager/index.js+27 -24 Viewed

     constructor() {
         // @ts-ignore
         this.spinnerElement = document.getElementById('connection_profile_spinner');
-        this.abortController =  new AbortController();
+        this.abortController = new AbortController();
+    }
     start() {

 /**
  * Renders the content of the details element.
- * @param {HTMLDetailsElement} details Details element
  * @param {HTMLElement} detailsContent Content element of the details
  */
-async function renderDetailsContent(details, detailsContent) {
+async function renderDetailsContent(detailsContent) {
     detailsContent.innerHTML = '';
-    if (details.open) {
+    if (detailsContent.classList.contains('hidden')) {
-        const selectedProfile = extension_settings.connectionManager.selectedProfile;
+        return;
-        const profile = extension_settings.connectionManager.profiles.find(p => p.id === selectedProfile);
+    }
-        if (profile) {
+    const selectedProfile = extension_settings.connectionManager.selectedProfile;
-            const profileForDisplay = makeFancyProfile(profile);
+    const profile = extension_settings.connectionManager.profiles.find(p => p.id === selectedProfile);
-            const template = await renderExtensionTemplateAsync(MODULE_NAME, 'view', { profile: profileForDisplay });
+    if (profile) {
-            detailsContent.innerHTML = template;
+        const profileForDisplay = makeFancyProfile(profile);
-        } else {
+        const template = await renderExtensionTemplateAsync(MODULE_NAME, 'view', { profile: profileForDisplay });
-            detailsContent.textContent = 'No profile selected';
+        detailsContent.innerHTML = template;
-        }
+    } else {
+        detailsContent.textContent = 'No profile selected';
+    }
+}

         const profileId = selectedProfile.value;
         extension_settings.connectionManager.selectedProfile = profileId;
         saveSettingsDebounced();
-        await renderDetailsContent(details, detailsContent);
+        await renderDetailsContent(detailsContent);
         // None option selected
         if (!profileId) {

             return;
+        }
         await applyConnectionProfile(profile);
-        await renderDetailsContent(details, detailsContent);
+        await renderDetailsContent(detailsContent);
         await eventSource.emit(event_types.CONNECTION_PROFILE_LOADED, profile.name);
         toastr.success('Connection profile reloaded', '', { timeOut: 1500 });
     });

         extension_settings.connectionManager.selectedProfile = profile.id;
         saveSettingsDebounced();
         renderConnectionProfiles(profiles);
-        await renderDetailsContent(details, detailsContent);
+        await renderDetailsContent(detailsContent);
         await eventSource.emit(event_types.CONNECTION_PROFILE_LOADED, profile.name);
     });

             return;
+        }
         await updateConnectionProfile(profile);
-        await renderDetailsContent(details, detailsContent);
+        await renderDetailsContent(detailsContent);
         saveSettingsDebounced();
         await eventSource.emit(event_types.CONNECTION_PROFILE_LOADED, profile.name);
         toastr.success('Connection profile updated', '', { timeOut: 1500 });

     deleteButton.addEventListener('click', async () => {
         await deleteConnectionProfile();
         renderConnectionProfiles(profiles);
-        await renderDetailsContent(details, detailsContent);
+        await renderDetailsContent(detailsContent);
         await eventSource.emit(event_types.CONNECTION_PROFILE_LOADED, NONE);
     });
-    /** @type {HTMLDetailsElement} */
+    /** @type {HTMLElement} */
-    // @ts-ignore
+    const viewDetails = document.getElementById('view_connection_profile');
-    const details = document.getElementById('connection_profile_details');
     const detailsContent = document.getElementById('connection_profile_details_content');
-    details.addEventListener('toggle', () => renderDetailsContent(details, detailsContent));
+    viewDetails.addEventListener('click', async () => {
+        viewDetails.classList.toggle('active');
+        detailsContent.classList.toggle('hidden');
+        await renderDetailsContent(detailsContent);
+    });
     SlashCommandParser.addCommandObject(SlashCommand.fromProps({
         name: 'profile',

             extension_settings.connectionManager.selectedProfile = profile.id;
             saveSettingsDebounced();
             renderConnectionProfiles(profiles);
-            await renderDetailsContent(details, detailsContent);
+            await renderDetailsContent(detailsContent);
             return profile.name;
         },
     }));

                 return '';
+            }
             await updateConnectionProfile(profile);
-            await renderDetailsContent(details, detailsContent);
+            await renderDetailsContent(detailsContent);
             saveSettingsDebounced();
             return profile.name;
         },

public/scripts/extensions/connection-manager/settings.html+2 -7 Viewed

     </div>
     <div class="flex-container">
         <select class="text_pole flex1" id="connection_profiles"></select>
+        <i id="view_connection_profile" class="menu_button fa-solid fa-info-circle" title="View connection profile details" data-i18n="[title]View connection profile details"></i>
         <i id="create_connection_profile" class="menu_button fa-solid fa-file-circle-plus" title="Create a new connection profile" data-i18n="[title]Create a new connection profile"></i>
         <i id="update_connection_profile" class="menu_button fa-solid fa-save" title="Update a connection profile" data-i18n="[title]Update a connection profile"></i>
         <i id="reload_connection_profile" class="menu_button fa-solid fa-recycle" title="Reload a connection profile" data-i18n="[title]Reload a connection profile"></i>
         <i id="delete_connection_profile" class="menu_button fa-solid fa-trash-can" title="Delete a connection profile" data-i18n="[title]Delete a connection profile"></i>
     </div>
-    <details id="connection_profile_details" class="marginBot10">
+    <div id="connection_profile_details_content" class="hidden"></div>
-        <summary>
-            <span data-i18n="Profile Details">Profile Details</span>
-            <i id="connection_profile_spinner" class="fa-solid fa-spinner fa-spin hidden"></i>
-        </summary>
-        <div id="connection_profile_details_content" class="marginTop5"></div>
-    </details>
 </div>

public/scripts/extensions/connection-manager/style.css+5 -7 Viewed

@@ -1,13 +1,11 @@
1	#connection_profile_details>summary {	1	#connection_profile_details_content {
2	cursor: pointer;	2	margin: 5px 0;
3	font-weight: bold;
4	font-size: 1.1em;
5	}	3	}
6		4
7	#connection_profile_details ul {	5	#connection_profile_details_content ul {
8	margin: 5px 0;	6	margin: 0;
9	}	7	}
10		8
11	#connection_profile_spinner {	9	#connection_profile_spinner {
12	margin-lefT: 5px;	10	margin-left: 5px;
13	}	11	}