Declare compiler in the inner scope #3272

49fb2f4d792cc2902c84f3706ccfe2adcc5d8d9e

Cohee <18619528+Cohee1207@users.noreply.github.com>

1 files changed, +2 -11Ignore whitespace
src/middleware/webpack-serve.js+2 -11
@@ -5,8 +5,6 @@ import { publicLibConfig } from '../../webpack.config.js';
55export default function getWebpackServeMiddleware() {
66 const outputPath = publicLibConfig.output?.path;
77 const outputFile = publicLibConfig.output?.filename;
8- /** @type {import('webpack').Compiler|null} */
9- let compiler = webpack(publicLibConfig);
108
119 /**
1210 * A very spartan recreation of webpack-dev-middleware.
@@ -28,12 +26,9 @@ export default function getWebpackServeMiddleware() {
2826 * @returns {Promise<void>}
2927 */
3028 devMiddleware.runWebpackCompiler = () => {
31- return new Promise((resolve) => {
29+ const compiler = webpack(publicLibConfig);
32- if (compiler === null) {
33- console.warn('Webpack compiler is already closed.');
34- return resolve();
35- }
3630
31+ return new Promise((resolve) => {
3732 console.log();
3833 console.log('Compiling frontend libraries...');
3934 compiler.run((_error, stats) => {
@@ -42,11 +37,7 @@ export default function getWebpackServeMiddleware() {
4237 console.log(output);
4338 console.log();
4439 }
45- if (compiler === null) {
46- return resolve();
47- }
4840 compiler.close(() => {
49- compiler = null;
5041 resolve();
5142 });
5243 });