Show error popup if extension update fails

58ac7464426c4323a2f5af5cc47885dca17a32b5

ceruleandeep <deep@cerulean.navy>

public/scripts/extensions.js+13 -3 Viewed

 /**
  * Handles the click event for the update button of an extension.
- * This function makes a POST request to '/update_extension' with the extension's name.
+ * This function makes a POST request to '/api/extensions/update' with the extension's name.
  * If the extension is already up to date, it displays a success message.
  * If the extension is not up to date, it updates the extension and displays a success message with the new commit hash.
  */

@@ -783,8 +783,11 @@ async function onUpdateClick() {
783	return;	783	return;
784	}	784	}
785		785
786	$(this).find('i').addClass('fa-spin');	786	const icon = $(this).find('i');
		787	icon.addClass('fa-spin');
787	await updateExtension(extensionName, false);	788	await updateExtension(extensionName, false);
		789	// updateExtension eats the error, but we can at least stop the spinner
		790	icon.removeClass('fa-spin');
788	}	791	}
789		792
790	/**	793	/**

             }),
         });
+        if (!response.ok) {
+            const text = await response.text();
+            toastr.error(text || response.statusText, t`Extension update failed`, { timeOut: 5000 });
+            console.error('Extension update failed', response.status, response.statusText, text);
+            return;
+        }
         const data = await response.json();
         if (!quiet) {
-            showExtensionsDetails();
+            await showExtensionsDetails();
+        }
         if (data.isUpToDate) {