Refactor if checks on /sendas

5952c3540232a8b3235d9dfbc49a7b27616c689c

Wolfsblvt <wolfsblvt@gmail.com>

public/scripts/slash-commands.js+3 -13 Viewed

 export async function sendMessageAs(args, text) {
     if (!text) {
+        toastr.warning('You must specify text to send as');
         return '';
+    }
-    let name;
+    let name = args.name?.trim();
     let mesText;
-    if (args.name) {
+    if (!name) {
-        name = args.name.trim();
-        if (!name && !text) {
-            toastr.warning('You must specify a name and text to send as');
-            return '';
-        }
-    } else {
         const namelessWarningKey = 'sendAsNamelessWarningShown';
         if (localStorage.getItem(namelessWarningKey) !== 'true') {
             toastr.warning('To avoid confusion, please use /sendas name="Character Name"', 'Name defaulted to {{char}}', { timeOut: 10000 });
             localStorage.setItem(namelessWarningKey, 'true');
+        }
         name = name2;
-        if (!text) {
-            toastr.warning('You must specify text to send as');
-            return '';
-        }
+    }
     mesText = text.trim();