Only convert variable if needed

6f85327078e1abd841a3cba9da71d254c5984aa7

Cohee <18619528+Cohee1207@users.noreply.github.com>

public/scripts/slash-commands/SlashCommandScope.js+4 -5 Viewed

         this.variables[key] = value;
+    }
     setVariable(key, value, index = null, type = null) {
 -        value = convertValueType(value, type);
         if (this.existsVariableInScope(key)) {
             if (index !== null && index !== undefined) {
                 let v = this.variables[key];

                     v = JSON.parse(v);
                     const numIndex = Number(index);
                     if (Number.isNaN(numIndex)) {
                         v[index] = convertValueType(value, type);
                     } else {
                         v[numIndex] = convertValueType(value, type);
+                    }
                     v = JSON.stringify(v);
                 } catch {
                     v[index] = convertValueType(value, type);
+                }
                 this.variables[key] = v;
             } else {

@@ -80,7 +79,7 @@ export class SlashCommandScope {
80	79	return value;
81	80	}
82	81	if (this.parent) {
83	82	return this.parent.setVariable(key, value, index, type);
84	83	}
85	84	throw new SlashCommandScopeVariableNotFoundError(`No such variable: "${key}"`);
86	85	}

public/scripts/variables.js+4 -6 Viewed

     if (args.index !== undefined) {
         try {
 -            value = convertValueType(value, args.type);
             let localVariable = JSON.parse(chat_metadata.variables[name] ?? 'null');
             const numIndex = Number(args.index);
             if (Number.isNaN(numIndex)) {
                 if (localVariable === null) {
                     localVariable = {};
+                }
                 localVariable[args.index] = convertValueType(value, args.type);
             } else {
                 if (localVariable === null) {
                     localVariable = [];
+                }
                 localVariable[numIndex] = convertValueType(value, args.type);
+            }
             chat_metadata.variables[name] = JSON.stringify(localVariable);
         } catch {

 function setGlobalVariable(name, value, args = {}) {
     if (args.index !== undefined) {
         try {
 -            value = convertValueType(value, args.type);
             let globalVariable = JSON.parse(extension_settings.variables.global[name] ?? 'null');
             const numIndex = Number(args.index);
             if (Number.isNaN(numIndex)) {
                 if (globalVariable === null) {
                     globalVariable = {};
+                }
                 globalVariable[args.index] = convertValueType(value, args.type);
             } else {
                 if (globalVariable === null) {
                     globalVariable = [];
+                }
                 globalVariable[numIndex] = convertValueType(value, args.type);
+            }
             extension_settings.variables.global[name] = JSON.stringify(globalVariable);
         } catch {