refactor(Middleware): only mount accessLogger when listen is enabled

9c3e8c935b7a7002294dabfdd84b7905455f55f7

KevinSun <paver.mails+github@gmail.com>

Signed
Parents: bfc609c2a8fa0743e72d49278e72ec48cbc416d0
2 files changed, +5 -4Ignore whitespace
server.js+3 -1
@@ -344,7 +344,9 @@ app.use(CORS);
344if (listen && basicAuthMode) app.use(basicAuthMiddleware);344if (listen && basicAuthMode) app.use(basicAuthMiddleware);
345345
346app.use(whitelistMiddleware(enableWhitelist));346app.use(whitelistMiddleware(enableWhitelist));
347app.use(accessLoggerMiddleware(listen));347if (listen) {
348 app.use(accessLoggerMiddleware());
349}
348350
349if (enableCorsProxy) {351if (enableCorsProxy) {
350 app.use(bodyParser.json({352 app.use(bodyParser.json({
src/middleware/accessLogger.js+2 -3
@@ -28,15 +28,14 @@ export function migrateAccessLog() {
2828
29/**29/**
30 * Creates middleware for logging access and new connections30 * Creates middleware for logging access and new connections
31 * @param {boolean} listen If listen mode is enabled via config or command line
32 * @returns {import('express').RequestHandler}31 * @returns {import('express').RequestHandler}
33 */32 */
34export default function accessLoggerMiddleware(listen) {33export default function accessLoggerMiddleware() {
35 return function (req, res, next) {34 return function (req, res, next) {
36 const clientIp = getRealIpFromHeader(req);35 const clientIp = getRealIpFromHeader(req);
37 const userAgent = req.headers['user-agent'];36 const userAgent = req.headers['user-agent'];
3837
39 if (listen && !knownIPs.has(clientIp)) {38 if (!knownIPs.has(clientIp)) {
40 // Log new connection39 // Log new connection
41 console.info(color.yellow(`New connection from ${clientIp}; User Agent: ${userAgent}\n`));40 console.info(color.yellow(`New connection from ${clientIp}; User Agent: ${userAgent}\n`));
42 knownIPs.add(clientIp);41 knownIPs.add(clientIp);