Refactor and fix type errors in WI and script modules (#4123) * remove unnecessary arg passage from WI helper funcs * remove some typescript red from script.js * hide in shame * Add JSDoc to helper functions * Fix fav_ch_checked not updating * Move PWA mode match to firstLoadInit * Fix more type errors and deprecations * Fix the rest of type errors in script.js --------- Co-authored-by: RossAscends <124905043+RossAscends@users.noreply.github.com>

b3c636fe91159a8be475512f35dff347a3f87ab0

Cohee <18619528+Cohee1207@users.noreply.github.com>

Signed

Parents: 358bbf86222a847a102f671d68eee37dd2a3e363

public/global.d.ts+5 -0 Viewed

         izoomify(options?: any): JQuery;
+    }
+    // NPM package doesn't have the 'queue' property in the type definition
+    interface JQueryTransitOptions {
+        queue?: boolean;
+    }
     namespace Select2 {
         interface Options<Result = DataFormat | GroupedDataFormat, RemoteResult = any> {
             /**

public/script.js+94 -89 Viewed

     };
+}
-// Register configuration migrations
-registerPromptManagerMigration();
-$(document).ajaxError(function myErrorHandler(_, xhr) {
-    // Cohee: CSRF doesn't error out in multiple tabs anymore, so this is unnecessary
-    /*
-    if (xhr.status == 403) {
-        toastr.warning(
-            'doubleCsrf errors in console are NORMAL in this case. If you want to run ST in multiple tabs, start the server with --disableCsrf option.',
-            'Looks like you\'ve opened SillyTavern in another browser tab',
-            { timeOut: 0, extendedTimeOut: 0, preventDuplicates: true },
-        );
-    } */
-});
 async function getClientVersion() {
     try {
         const response = await fetch('/version');

     creator: '',
     personality: '',
     first_message: '',
-    avatar: '',
+    /** @type {FileList|null} */
+    avatar: null,
     scenario: '',
     mes_example: '',
     world: '',

+    }
     showLoader();
+    registerPromptManagerMigration();
+    initStandaloneMode();
     initLibraryShims();
     addShowdownPatch(showdown);
     reloadMarkdownProcessor();

     document.body.style.position = '';
+}
+function initStandaloneMode() {
+    const isPwaMode = window.matchMedia('(display-mode: standalone)').matches;
+    if (isPwaMode) {
+        $('body').addClass('PWA');
+    }
+}
 function cancelStatusCheck(reason = 'Manually cancelled status check') {
     abortStatusCheck?.abort(new AbortReason(reason));
     abortStatusCheck = new AbortController();

@@ -1396,7 +1391,6 @@ export function resultCheckStatus() {
1396	stopStatusLoading();	1391	stopStatusLoading();
1397	}	1392	}
1398		1393
1399
1400	/**	1394	/**
1401	* Switches the currently selected character to the one with the given ID. (character index, not the character key!)	1395	* Switches the currently selected character to the one with the given ID. (character index, not the character key!)
1402	*	1396	*

         if (responseLengthCustomized) {
             TempResponseLength.save(api, responseLength);
+        }
+        /** @type {object|any[]} */
         let generateData = {};
         switch (api) {

+    }
+}
+/**
+ * Processes the avatar image from the input element, allowing the user to crop it if necessary.
+ * @param {HTMLInputElement} input - The input element containing the avatar file.
+ * @returns {Promise<void>}
+ */
 async function read_avatar_load(input) {
     if (input.files && input.files[0]) {
         if (selected_button == 'create') {

         await createOrEditCharacter();
         await delay(DEFAULT_SAVE_EDIT_TIMEOUT);
-        const formData = new FormData($('#form_create').get(0));
+        const formData = new FormData(/** @type {HTMLFormElement} */($('#form_create').get(0)));
         await fetch(getThumbnailUrl('avatar', formData.get('avatar_url')), {
             method: 'GET',
             cache: 'no-cache',

             },
         });
-        $('.mes').each(async function () {
+        const messages = $('.mes').toArray();
-            const nameMatch = $(this).attr('ch_name') == formData.get('ch_name');
+        for (const el of messages) {
-            if ($(this).attr('is_system') == 'true' && !nameMatch) {
+            const $el = $(el);
-                return;
+            const nameMatch = $el.attr('ch_name') == formData.get('ch_name');
-            }
+            if ($el.attr('is_system') == 'true' && !nameMatch) continue;
-            if ($(this).attr('is_user') == 'true') {
+            if ($el.attr('is_user') == 'true') continue;
-                return;
-            }
             if (nameMatch) {
                 const previewSrc = $('#avatar_load_preview').attr('src');
-                const avatar = $(this).find('.avatar img');
+                const avatar = $el.find('.avatar img');
                 avatar.attr('src', default_avatar);
                 await delay(1);
                 avatar.attr('src', previewSrc);
+            }
-        });
+        }
         console.log('Avatar refreshed');
+    }

  * response is an object with an `error` property set to `true`.
  */
 export async function getPastCharacterChats(characterId = null) {
-    characterId = characterId ?? this_chid;
+    characterId = characterId ?? parseInt(this_chid);
     if (!characters[characterId]) return [];
     const response = await fetch('/api/characters/chats', {

     // UX convenience: Focus the search field when the Manage Chat Files view opens.
     setTimeout(function () {
         const textSearchElement = $('#select_chat_search');
-        textSearchElement.click();
+        textSearchElement.trigger('click').trigger('focus').trigger('select');
-        textSearchElement.focus();
-        textSearchElement.select();  // select content (if any) for easy erasing
     }, 200);
+}

     switchMenu && setMenuType('create');
     //console.log('select_rm_Create() -- selected button: '+selected_button);
-    if (selected_button == 'create') {
+    if (selected_button == 'create' && create_save.avatar) {
-        if (create_save.avatar != '') {
+        const addAvatarInput = /** @type {HTMLInputElement} */ ($('#add_avatar_button').get(0));
-            $('#add_avatar_button').get(0).files = create_save.avatar;
+        addAvatarInput.files = create_save.avatar;
-            read_avatar_load($('#add_avatar_button').get(0));
+        read_avatar_load(addAvatarInput);
-        }
+    }
     switchMenu && selectRightMenuWithAnimation('rm_ch_create_block');

     chat_metadata = reset ? { ...newValues } : { ...chat_metadata, ...newValues };
+}
+/**
+ * Updates the state of the favorite button based on the provided state.
+ * @param {boolean} state Whether the favorite button should be on or off.
+ */
 function updateFavButtonState(state) {
+    // Update global state of the flag
+    // TODO: This is bad and needs to be refactored.
     fav_ch_checked = state;
-    $('#fav_checkbox').val(fav_ch_checked);
+    $('#fav_checkbox').prop('checked', state);
-    $('#favorite_button').toggleClass('fav_on', fav_ch_checked);
+    $('#favorite_button').toggleClass('fav_on', state);
-    $('#favorite_button').toggleClass('fav_off', !fav_ch_checked);
+    $('#favorite_button').toggleClass('fav_off', !state);
+}
 export async function setScenarioOverride() {

@@ -8830,7 +8833,7 @@ function updateEditArrowClasses() {
8830	export function closeMessageEditor(what = 'all') {	8833	export function closeMessageEditor(what = 'all') {
8831	if (what === 'message' \|\| what === 'all') {	8834	if (what === 'message' \|\| what === 'all') {
8832	if (this_edit_mes_id) {	8835	if (this_edit_mes_id) {
8833	$(`#chat .mes[mesid="${this_edit_mes_id}"] .mes_edit_cancel`).click();	8836	$(`#chat .mes[mesid="${this_edit_mes_id}"] .mes_edit_cancel`).trigger('click');
8834	}	8837	}
8835	}	8838	}
8836	if (what === 'reasoning' \|\| what === 'all') {	8839	if (what === 'reasoning' \|\| what === 'all') {

+    }
     function onExtraWorldInfoChanged() {
-        const selectedWorlds = $('.character_extra_world_info_selector').val();
+        const selectorFieldValue = $('.character_extra_world_info_selector').val();
+        const selectedWorlds = Array.isArray(selectorFieldValue) ? selectorFieldValue : [];
         let charLore = world_info.charLore ?? [];
         // TODO: Maybe make this utility function not use the window context?

     // Apped to base dropdown
     world_names.forEach((item, i) => {
         const option = document.createElement('option');
-        option.value = i;
+        option.value = String(i);
         option.innerText = item;
         option.selected = item === worldId;
         select.append(option);

+    }
     world_names.forEach((item, i) => {
         const option = document.createElement('option');
-        option.value = i;
+        option.value = String(i);
         option.innerText = item;
         const existingCharLore = world_info.charLore?.find((e) => e.name === getCharaFilename());

  */
 async function createOrEditCharacter(e) {
     $('#rm_info_avatar').html('');
-    const formData = new FormData($('#form_create').get(0));
+    const formData = new FormData(/** @type {HTMLFormElement} */($('#form_create').get(0)));
     formData.set('fav', String(fav_ch_checked));
     const isNewChat = e instanceof CustomEvent && e.type === 'newChat';

             $('#character_popup-button-h3').text('Create character');
-            create_save.avatar = '';
+            create_save.avatar = null;
             $('#add_avatar_button').replaceWith(
                 $('#add_avatar_button').val('').clone(true),

     return getCurrentChatDetails().sessionName;
+}
-const isPwaMode = window.navigator.standalone;
-if (isPwaMode) { $('body').addClass('PWA'); }
 function doCharListDisplaySwitch() {
     power_user.charListGrid = !power_user.charListGrid;
     document.body.classList.toggle('charListGrid', power_user.charListGrid);

     //menu buttons setup
-    $('#rm_button_settings').click(function () {
+    $('#rm_button_settings').on('click', function () {
         selected_button = 'settings';
         selectRightMenuWithAnimation('rm_api_block');
     });
-    $('#rm_button_characters').click(function () {
+    $('#rm_button_characters').on('click', function () {
         selected_button = 'characters';
         select_rm_characters();
     });
-    $('#rm_button_back').click(function () {
+    $('#rm_button_back').on('click', function () {
         selected_button = 'characters';
         select_rm_characters();
     });
-    $('#rm_button_create').click(function () {
+    $('#rm_button_create').on('click', function () {
         selected_button = 'create';
         select_rm_create();
     });
-    $('#rm_button_selected_ch').click(function () {
+    $('#rm_button_selected_ch').on('click', function () {
         if (selected_group) {
             select_group_chats(selected_group);
         } else {

         callPopup('<h3>' + t`Delete the Chat File?` + '</h3>', 'del_chat');
     });
-    $('#advanced_div').click(function () {
+    $('#advanced_div').on('click', function () {
         if (!is_advanced_char_open) {
             is_advanced_char_open = true;
             $('#character_popup').css({ 'display': 'flex', 'opacity': 0.0 }).addClass('open');

+        }
     });
-    $('#character_cross').click(function () {
+    $('#character_cross').on('click', function () {
         is_advanced_char_open = false;
         $('#character_popup').transition({
             opacity: 0,

         setTimeout(function () { $('#character_popup').css('display', 'none'); }, animation_duration);
     });
-    $('#character_popup_ok').click(function () {
+    $('#character_popup_ok').on('click', function () {
         is_advanced_char_open = false;
         $('#character_popup').css('display', 'none');
     });
-    $('#dialogue_popup_ok').click(async function (e, customData) {
+    $('#dialogue_popup_ok').on('click', async function (_e, customData) {
         const fromSlashCommand = customData?.fromSlashCommand || false;
         dialogueCloseStop = false;
         $('#shadow_popup').transition({

                 hideLoader();
             } else {  // Open the history view again after 2 seconds (delay to avoid edge cases for deleting last chat).
                 setTimeout(function () {
-                    $('#option_select_chat').click();
+                    $('#option_select_chat').trigger('click');
                     $('#options').hide();  // hide option popup menu
                     hideLoader();
                 }, 2000);

@@ -10941,18 +10942,16 @@ jQuery(async function () {
10941	if (popup_type == 'input') {	10942	if (popup_type == 'input') {
10942	dialogueResolve($('#dialogue_popup_input').val());	10943	dialogueResolve($('#dialogue_popup_input').val());
10943	$('#dialogue_popup_input').val('');	10944	$('#dialogue_popup_input').val('');
10944
10945	}	10945	}
10946	else {	10946	else {
10947	dialogueResolve(true);	10947	dialogueResolve(true);
10948
10949	}	10948	}
10950		10949
10951	dialogueResolve = null;	10950	dialogueResolve = null;
10952	}	10951	}
10953	});	10952	});
10954		10953
10955	$('#dialogue_popup_cancel').click(function (e) {	10954	$('#dialogue_popup_cancel').on('click', function (e) {
10956	dialogueCloseStop = false;	10955	dialogueCloseStop = false;
10957	$('#shadow_popup').transition({	10956	$('#shadow_popup').transition({
10958	opacity: 0,	10957	opacity: 0,

             $('#dialogue_popup').removeClass('large_dialogue_popup');
         }, animation_duration);
-        //$("#shadow_popup").css("opacity:", 0.0);
         popup_type = '';
         if (dialogueResolve) {
             dialogueResolve(false);
             dialogueResolve = null;
+        }
     });
-    $('#add_avatar_button').change(function () {
+    $('#add_avatar_button').on('change', function () {
-        read_avatar_load(this);
+        const inputElement = /** @type {HTMLInputElement} */ (this);
+        read_avatar_load(inputElement);
     });
-    $('#form_create').submit(createOrEditCharacter);
+    $('#form_create').on('submit', (e) => createOrEditCharacter(e.originalEvent));
     $('#delete_button').on('click', async function () {
         if (this_chid === undefined || !characters[this_chid]) {

         let deleteChats = false;
         const confirm = await Popup.show.confirm(t`Delete the character?`, await renderTemplateAsync('deleteConfirm'), {
-            onClose: () => deleteChats = !!$('#del_char_checkbox').prop('checked'),
+            onClose: () => { deleteChats = !!$('#del_char_checkbox').prop('checked'); },
         });
         if (!confirm) {
             return;

     ///////////////////////////////////////////////////////////////////////////////////
-    $('#api_button').click(function (e) {
+    $('#api_button').on('click', function (e) {
         if ($('#api_url_text').val() != '') {
             let value = formatKoboldUrl(String($('#api_url_text').val()).trim());

             if ((selected_group || this_chid !== undefined) && !is_send_press) {
                 let deleteCurrentChat = false;
                 const result = await Popup.show.confirm(t`Start new chat?`, await renderTemplateAsync('newChatConfirm'), {
-                    onClose: () => deleteCurrentChat = !!$('#del_chat_checkbox').prop('checked'),
+                    onClose: () => { deleteCurrentChat = !!$('#del_chat_checkbox').prop('checked'); },
                 });
                 if (!result) {
                     return;

     //////////////////////////////////////////////////////////////////////////////////////////////
     //functionality for the cancel delete messages button, reverts to normal display of input form
-    $('#dialogue_del_mes_cancel').click(function () {
+    $('#dialogue_del_mes_cancel').on('click', function () {
         $('#dialogue_del_mes').css('display', 'none');
         $('#send_form').css('display', css_send_form_display);
         $('.del_checkbox').each(function () {

     //////////////////////////////////////////////////////////////
-    $('#select_chat_cross').click(function () {
+    $('#select_chat_cross').on('click', function () {
         $('#shadow_select_chat_popup').transition({
             opacity: 0,
             duration: animation_duration,

                 edit_textarea.height(0);
                 edit_textarea.height(edit_textarea[0].scrollHeight);
+            }
-            edit_textarea.focus();
+            edit_textarea.trigger('focus');
-            edit_textarea[0].setSelectionRange(     //this sets the cursor at the end of the text
+            const textAreaElement = /** @type {HTMLTextAreaElement} */ (edit_textarea[0]);
+            // Sets the cursor at the end of the text
+            textAreaElement.setSelectionRange(
                 String(edit_textarea.val()).length,
                 String(edit_textarea.val()).length,
             );

     //Select chat
     //**************************CHARACTER IMPORT EXPORT*************************//
-    $('#character_import_button').click(function () {
+    $('#character_import_button').on('click', function () {
-        $('#character_import_file').click();
+        $('#character_import_file').trigger('click');
     });
     $('#character_import_file').on('change', async function (e) {

+        }
     });
     //**************************CHAT IMPORT EXPORT*************************//
-    $('#chat_import_button').click(function () {
+    $('#chat_import_button').on('click', function () {
-        $('#chat_import_file').click();
+        $('#chat_import_file').trigger('click');
     });
     $('#chat_import_file').on('change', async function (e) {
-        const file = e.target.files[0];
+        const targetElement = /** @type {HTMLInputElement} */ (e.target);
+        if (!(targetElement instanceof HTMLInputElement)) {
+            return;
+        }
+        const file = targetElement.files[0];
         if (!file) {
             return;

         const format = ext[1].toLowerCase();
         $('#chat_import_file_type').val(format);
-        const formData = new FormData($('#form_import_chat').get(0));
+        const formData = new FormData(/** @type {HTMLFormElement} */($('#form_import_chat').get(0)));
         formData.append('user_name', name1);
         $('#select_chat_div').html('');

+        }
     });
-    $('#rm_button_group_chats').click(function () {
+    $('#rm_button_group_chats').on('click', function () {
         selected_button = 'group_chats';
         select_group_chats();
     });
-    $('#rm_button_back_from_group').click(function () {
+    $('#rm_button_back_from_group').on('click', function () {
         selected_button = 'characters';
         select_rm_characters();
     });

@@ -12025,7 +12029,7 @@ jQuery(async function () {
12025	}	12029	}
12026	});	12030	});
12027		12031
12028	$(document).on('click', '.inline-drawer-toggle', function (e) {	12032	$(document).on('click', '.inline-drawer-toggle', async function (e) {
12029	if ($(e.target).hasClass('text_pole')) {	12033	if ($(e.target).hasClass('text_pole')) {
12030	return;	12034	return;
12031	}	12035	}

         // Set the height of "autoSetHeight" textareas within the inline-drawer to their scroll height
         if (!CSS.supports('field-sizing', 'content')) {
-            drawerContent.find('textarea.autoSetHeight').each(async function () {
+            const textareas = drawerContent.find('textarea.autoSetHeight');
-                await resetScrollHeight($(this));
+            for (const textarea of textareas) {
-                return;
+                await resetScrollHeight($(textarea));
-            });
+            }
+        }
     });

                 return;
+            }
             if (isEditVisible && power_user.auto_save_msg_edits === true) {
-                $(`#chat .mes[mesid="${this_edit_mes_id}"] .mes_edit_done`).click();
+                $(`#chat .mes[mesid="${this_edit_mes_id}"] .mes_edit_done`).trigger('click');
                 closeMessageEditor('reasoning');
                 $('#send_textarea').focus();
                 return;

     });
     $('#char-management-dropdown').on('change', async (e) => {
-        let target = $(e.target.selectedOptions).attr('id');
+        const targetElement = /** @type {HTMLSelectElement} */ (e.target);
+        const target = $(targetElement.selectedOptions).attr('id');
         switch (target) {
             case 'set_character_world':
                 openCharacterWorldPopup();

public/scripts/world-info.js+89 -41 Viewed

+    }
+}
-//MARK: getWorldEntry
+/**
+ * Enables the input helper for keys in a World Info entry.
+ * @param {object} params - Parameters for enabling the keys input helper.
+ * @param {JQuery<HTMLElement>} params.template - The template element containing the input.
+ * @param {object} params.entry - The entry object containing the keys.
+ * @param {string} params.entryPropName - The property name of the entry that holds the keys.
+ * @param {string} params.originalDataValueName - The name of the original data value to be set.
+ * @param {string} params.name - The name of the world info entry.
+ * @param {object} params.data - The data object containing entries.
+ */
 function enableKeysInputHelper({ template, entry, entryPropName, originalDataValueName, name, data }) {
     const isFancyInput = !isMobile() && !power_user.wi_key_input_plaintext;
     const input = isFancyInput ? template.find(`select[name="${entryPropName}"]`) : template.find(`textarea[name="${entryPropName}"]`);

 /**
  * Helper to handle match checkboxes for WI entries.
+ * @param {object} params - Parameters for handling match checkboxes.
+ * @param {JQuery<HTMLElement>} params.template - The template element containing the checkbox.
+ * @param {object} params.entry - The entry object containing the checkbox state.
+ * @param {string} params.fieldName - The name of the checkbox field.
+ * @param {object} params.data - The data object containing entries.
+ * @param {string} params.name - The name of the world info to save changes to.
  */
 function handleMatchCheckboxHelper({ template, entry, fieldName, data, name }) {
     const key = originalWIDataKeyMap[fieldName];

 /**
  * Helper to update position/order display.
+ * @param {object} params - Parameters for updating position/order display.
+ * @param {JQuery<HTMLElement>} params.template - The template element containing the display.
+ * @param {object} params.data - The data object containing entries.
+ * @param {string} params.uid - The unique identifier of the entry to update.
  */
 function updatePosOrdDisplayHelper({ template, data, uid }) {
     let entry = data.entries[uid];

 /**
  * Helper to initialize character filter select2.
+ * @param {JQuery<HTMLElement>} characterFilter - The select element for character filter.
  */
-function initCharacterFilterSelect2Helper(characterFilter, t) {
+function initCharacterFilterSelect2Helper(characterFilter) {
     if (!isMobile()) {
         $(characterFilter).select2({
             width: '100%',

 /**
  * Helper to fill character and tag options for character filter.
+ * @param {object} params - Parameters for filling options.
+ * @param {JQuery<HTMLElement>} params.characterFilter - The select element to fill with options.
+ * @param {object} params.entry - The entry object containing character filter data.
  */
-function fillCharacterAndTagOptionsHelper({ characterFilter, entry, getContext }) {
+function fillCharacterAndTagOptionsHelper({ characterFilter, entry }) {
     const characters = getContext().characters;
     characters.forEach((character) => {
         const option = document.createElement('option');

 /**
  * Helper to handle character filter changes.
+ * @param {object} params - Parameters for handling character filter changes.
+ * @param {JQuery<HTMLElement>} params.characterFilter - The select element for character filter.
+ * @param {object} params.data - The data object containing entries.
+ * @param {object} params.entry - The entry object to update.
+ * @param {string} params.name - The name of the world info to save changes to.
  */
-function handleCharacterFilterChangeHelper({ characterFilter, data, entry, name, world_names, getContext, setWIOriginalDataValue, saveWorldInfo, t }) {
+function handleCharacterFilterChangeHelper({ characterFilter, data, entry, name }) {
     characterFilter.on('mousedown change', async function (e) {
         if (world_names.length === 0) {
             e.preventDefault();

 /**
  * Helper to handle probability input.
+ * @param {object} params - Parameters for handling probability input.
+ * @param {JQuery<HTMLElement>} params.probabilityInput - The input element for probability.
+ * @param {object} params.data - The data object containing entries.
+ * @param {object} params.entry - The entry object to update.
+ * @param {string} params.name - The name of the world info to save changes to.
  */
-function handleProbabilityInputHelper({ probabilityInput, data, entry, name, setWIOriginalDataValue, saveWorldInfo }) {
+function handleProbabilityInputHelper({ probabilityInput, data, entry, name }) {
     probabilityInput.data('uid', entry.uid);
     probabilityInput.on('input', async function (_, { noSave = false } = {}) {
         const uid = $(this).data('uid');

 /**
  * Helper to handle probability toggle.
+ * @param {object} params - Parameters for handling probability toggle.
+ * @param {JQuery<HTMLElement>} params.probabilityToggle - The toggle element for probability.
+ * @param {object} params.data - The data object containing entries.
+ * @param {object} params.entry - The entry object to update.
+ * @param {string} params.name - The name of the world info to save changes to.
+ * @param {JQuery<HTMLElement>} params.probabilityInput - The input element for probability.
  */
-function handleProbabilityToggleHelper({ probabilityToggle, data, entry, name, probabilityInput, setWIOriginalDataValue, saveWorldInfo }) {
+function handleProbabilityToggleHelper({ probabilityToggle, data, entry, name, probabilityInput }) {
     probabilityToggle.data('uid', entry.uid);
     probabilityToggle.on('input', async function (_, { noSave = false } = {}) {
         const uid = $(this).data('uid');

 /**
  * Helper to handle select2 dropdowns for boolean selects.
+ * @param {object} params - Parameters for handling boolean selects.
+ * @param {JQuery<HTMLElement>} params.selectElem - The select element for boolean values.
+ * @param {object} params.entry - The entry object containing the boolean value.
+ * @param {string} params.entryKey - The key in the entry object for the boolean value.
+ * @param {object} params.data - The data object containing entries.
+ * @param {string} params.name - The name of the world info to save changes to.
  */
-function handleBooleanSelectHelper({ selectElem, entry, entryKey, data, name, setWIOriginalDataValue, saveWorldInfo }) {
+function handleBooleanSelectHelper({ selectElem, entry, entryKey, data, name }) {
     selectElem.data('uid', entry.uid);
     selectElem.on('input', async function (_, { noSave = false } = {}) {
         const uid = $(this).data('uid');

 /**
  * Helper to handle input fields for numbers.
+ * @param {object} params - Parameters for handling number inputs.
+ * @param {JQuery<HTMLElement>} params.inputElem - The input element for the number.
+ * @param {object} params.entry - The entry object containing the number value.
+ * @param {string} params.entryKey - The key in the entry object for the number value.
+ * @param {object} params.data - The data object containing entries.
+ * @param {string} params.name - The name of the world info to save changes to.
+ * @param {number} params.min - The minimum value for the number input.
+ * @param {number} params.max - The maximum value for the number input.
+ * @param {boolean} [params.clamp=false] - Whether to clamp the value within the min and max range.
  */
-function handleNumberInputHelper({ inputElem, entry, entryKey, data, name, setWIOriginalDataValue, saveWorldInfo, min, max, clamp = false }) {
+function handleNumberInputHelper({ inputElem, entry, entryKey, data, name, min, max, clamp = false }) {
     inputElem.data('uid', entry.uid);
     inputElem.on('input', async function (_, { noSave = false } = {}) {
         const uid = $(this).data('uid');

 /**
  * Helper to handle tri-state selector for constant/normal/vectorized.
+ * @param {object} params - Parameters for handling the entry state selector.
+ * @param {JQuery<HTMLElement>} params.entryStateSelector - The select element for entry state.
+ * @param {object} params.entry - The entry object containing the state.
+ * @param {object} params.data - The data object containing entries.
+ * @param {string} params.name - The name of the world info to save changes to.
  */
-function handleEntryStateSelectorHelper({ entryStateSelector, entry, data, name, setWIOriginalDataValue, saveWorldInfo }) {
+function handleEntryStateSelectorHelper({ entryStateSelector, entry, data, name }) {
     entryStateSelector.data('uid', entry.uid);
     entryStateSelector.on('click', function (event) {
         event.stopPropagation();

 /**
  * Helper to handle kill switch toggle.
+ * @param {object} params - Parameters for handling the kill switch toggle.
+ * @param {JQuery<HTMLElement>} params.entryKillSwitch - The toggle element for the kill switch.
+ * @param {object} params.entry - The entry object containing the state.
+ * @param {object} params.data - The data object containing entries.
+ * @param {string} params.name - The name of the world info to save changes to.
+ * @param {JQuery<HTMLElement>} params.template - The template element for the entry.
  */
-function handleEntryKillSwitchHelper({ entryKillSwitch, entry, data, name, setWIOriginalDataValue, saveWorldInfo, template }) {
+function handleEntryKillSwitchHelper({ entryKillSwitch, entry, data, name, template }) {
     entryKillSwitch.data('uid', entry.uid);
     entryKillSwitch.on('click', async function () {
         const uid = entry.uid;

     orderInput.css('width', 'calc(3em + 15px)');
     // Probability
-    handleProbabilityInputHelper({ probabilityInput: headerTemplate.find('input[name="probability"]'), data, entry, name, setWIOriginalDataValue, saveWorldInfo });
+    handleProbabilityInputHelper({ probabilityInput: headerTemplate.find('input[name="probability"]'), data, entry, name });
     // Depth
     handleNumberInputHelper({
         inputElem: headerTemplate.find('input[name="depth"]'),
-        entry, entryKey: 'depth', data, name, setWIOriginalDataValue, saveWorldInfo,
+        entry, entryKey: 'depth', data, name, min: 0, max: MAX_SCAN_DEPTH, clamp: false,
-        min: 0, max: MAX_SCAN_DEPTH, clamp: false,
     });
     headerTemplate.find('input[name="depth"]').css('width', 'calc(3em + 15px)');

     // Tri-state selector
     handleEntryStateSelectorHelper({
         entryStateSelector: headerTemplate.find('select[name="entryStateSelector"]'),
-        entry, data, name, setWIOriginalDataValue, saveWorldInfo,
+        entry, data, name,
     });
     // Kill switch
     handleEntryKillSwitchHelper({
         entryKillSwitch: headerTemplate.find('div[name="entryKillSwitch"]'),
-        entry, data, name, setWIOriginalDataValue, saveWorldInfo, template: headerTemplate,
+        entry, data, name, template: headerTemplate,
     });
     // Duplicate/delete/move buttons

             probabilityToggle: editTemplate.find('input[name="useProbability"]'),
             data, entry, name,
             probabilityInput: headerTemplate.find('input[name="probability"]'),
-            setWIOriginalDataValue, saveWorldInfo,
         });
         // Comment toggle

         const characterFilter = editTemplate.find('select[name="characterFilter"]');
         characterFilter.data('uid', entry.uid);
-        initCharacterFilterSelect2Helper(characterFilter, t);
+        initCharacterFilterSelect2Helper(characterFilter);
-        fillCharacterAndTagOptionsHelper({ characterFilter, entry, getContext });
+        fillCharacterAndTagOptionsHelper({ characterFilter, entry });
-        handleCharacterFilterChangeHelper({
+        handleCharacterFilterChangeHelper({ characterFilter, data, entry, name });
-            characterFilter, data, entry, name, world_names, getContext, setWIOriginalDataValue, saveWorldInfo, t,
-        });
         // Content
         const counter = editTemplate.find('.world_entry_form_token_counter');

         // Group weight
         handleNumberInputHelper({
             inputElem: editTemplate.find('input[name="groupWeight"]'),
-            entry, entryKey: 'groupWeight', data, name, setWIOriginalDataValue, saveWorldInfo,
+            entry, entryKey: 'groupWeight', data, name, min: 1, max: 10000, clamp: true,
-            min: 1, max: 10000, clamp: true,
         });
         // Sticky, cooldown, delay
         handleNumberInputHelper({
             inputElem: editTemplate.find('input[name="sticky"]'),
-            entry, entryKey: 'sticky', data, name, setWIOriginalDataValue, saveWorldInfo,
+            entry, entryKey: 'sticky', data, name, min: 1, max: 10000, clamp: false,
-            min: 1, max: 10000, clamp: false,
         });
         handleNumberInputHelper({
             inputElem: editTemplate.find('input[name="cooldown"]'),
-            entry, entryKey: 'cooldown', data, name, setWIOriginalDataValue, saveWorldInfo,
+            entry, entryKey: 'cooldown', data, name, min: 1, max: 10000, clamp: false,
-            min: 1, max: 10000, clamp: false,
         });
         handleNumberInputHelper({
             inputElem: editTemplate.find('input[name="delay"]'),
-            entry, entryKey: 'delay', data, name, setWIOriginalDataValue, saveWorldInfo,
+            entry, entryKey: 'delay', data, name, min: 1, max: 10000, clamp: false,
-            min: 1, max: 10000, clamp: false,
         });
         // Exclude/prevent recursion

         delayUntilRecursionLevelInput.val(['number', 'string'].includes(typeof entry.delayUntilRecursion) ? entry.delayUntilRecursion : '').trigger('input', { noSave: true });
         // Boolean selects
-        handleBooleanSelectHelper({
+        handleBooleanSelectHelper({ selectElem: editTemplate.find('select[name="caseSensitive"]'), entry, entryKey: 'caseSensitive', data, name });
-            selectElem: editTemplate.find('select[name="caseSensitive"]'),
+        handleBooleanSelectHelper({ selectElem: editTemplate.find('select[name="matchWholeWords"]'), entry, entryKey: 'matchWholeWords', data, name });
-            entry, entryKey: 'caseSensitive', data, name, setWIOriginalDataValue, saveWorldInfo,
+        handleBooleanSelectHelper({ selectElem: editTemplate.find('select[name="useGroupScoring"]'), entry, entryKey: 'useGroupScoring', data, name });
-        });
-        handleBooleanSelectHelper({
-            selectElem: editTemplate.find('select[name="matchWholeWords"]'),
-            entry, entryKey: 'matchWholeWords', data, name, setWIOriginalDataValue, saveWorldInfo,
-        });
-        handleBooleanSelectHelper({
-            selectElem: editTemplate.find('select[name="useGroupScoring"]'),
-            entry, entryKey: 'useGroupScoring', data, name, setWIOriginalDataValue, saveWorldInfo,
-        });
         // Match checkboxes
         handleMatchCheckboxHelper({ template: editTemplate, entry, fieldName: 'matchPersonaDescription', data, name });