Optimize cache verification

b625319f0cca5f25da1550362e57d8185d635df2

Cohee <18619528+Cohee1207@users.noreply.github.com>

src/endpoints/characters.js+25 -11 Viewed

     static DIRECTORY = 'characters';
     /** @type {number} */
     static REMOVAL_INTERVAL = 6000060 * 1000;
     /** @type {import('node-persist').LocalStorage} */
     #instance;

     removalQueue = [];
     /**
 +     * Path to the cache directory.
 +     * @returns {string}
 +     */
 +    get cachePath() {
 +        return path.join(globalThis.DATA_ROOT, '_cache', DiskCache.DIRECTORY);
 +    }
++
 +    /**
 +     * Returns the list of hashed keys in the cache.
 +     * @returns {string[]}
 +     */
 +    get hashedKeys() {
 +        return fs.readdirSync(this.cachePath);
 +    }
++
 +    /**
      * Processes the removal queue.
      * @returns {Promise<void>}
      */

             return this.#instance;
+        }
 -        const cacheDir = path.join(globalThis.DATA_ROOT, '_cache', DiskCache.DIRECTORY);
 +        this.#instance = storage.create({ dir: this.cachePath, ttl: false });
 -        this.#instance = storage.create({ dir: cacheDir, ttl: false });
         await this.#instance.init();
         this.#removalInterval = setInterval(this.#removeCacheEntries.bind(this), DiskCache.REMOVAL_INTERVAL);
         return this.#instance;

@@ -128,18 +143,17 @@ class DiskCache {
128	143	}
129	144
130	145	const cache = await this.instance();
131	146	const validKeys = []new Set();
132	147	for (const dir of directoriesList) {
133	148	const files = fs.readdirSync(dir.characters, { withFileTypes: true });
134		- for (const file of files) {
	149	+ for (const file of files.filter(f => f.isFile() && path.extname(f.name) === '.png')) {
135	150	const filePath = path.join(dir.characters, file.name);
136	151	const stat = fs.statSync(filePath);
137	152	validKeys.pushadd(path.parse(cache.getDatumPath(`${filePath}-${stat.mtimeMs}`)).base);
138	153	}
139	154	}
140		- const cacheKeys = await cache.keys();
	155	+ for (const key of this.hashedKeys) {
141		- for (const key of cacheKeys) {
	156	+ if (!validKeys.has(key)) {
142		- if (!validKeys.includes(key)) {
143	157	await cache.removeItem(key);
144	158	}
145	159	}