Prevent saveWorldInfo calls while rendering the list

b7323715b2693229f43bbecffea769484f89ed59

Cohee <18619528+Cohee1207@users.noreply.github.com>

Parents: 0f9cd5f48d9d3ac1c66e83d7c8581360915c5acf

public/scripts/world-info.js+39 -20 Viewed

 }, debounce_timeout.relaxed);
 const sortFn = (a, b) => b.order - a.order;
 let updateEditor = (navigation, flashOnNav = true) => { console.debug('Triggered WI navigation', navigation, flashOnNav); };
 +let isSaveWorldInfoDisabled = false;
 // Do not optimize. updateEditor is a function that is updated by the displayWorldEntries with new data.
 export const worldInfoFilter = new FilterHelper(() => updateEditor());

     const worldEntriesList = $('#world_popup_entries_list');
 -    // We save costly performance by removing all events before emptying. Because we know there are no relevant event handlers reacting on removing elements
 -    // This prevents jQuery from actually going through all registered events on the controls for each entry when removing it
 -    //worldEntriesList.find('*').off();
     worldEntriesList.css({ 'opacity': 0, 'transition': 'opacity 250ms ease-in-out' });
     await delay(250);
     clearEntryList(); // Use enhanced cleanup
     worldEntriesList.show();
     if (!data || !('entries' in data)) {

         formatNavigator: PAGINATION_TEMPLATE,
         showNavigator: true,
         callback: async function (/** @type {object[]} */ page) {
 -            // We save costly performance by removing all events before emptying. Because we know there are no relevant event handlers reacting on removing elements
 +            try {
 -            // This prevents jQuery from actually going through all registered events on the controls for each entry when removing it
 +                // Prevent saveWorldInfo from firing timeouts while rendering the list
 -            //worldEntriesList.find('*').off();
 +                isSaveWorldInfoDisabled = true;
                             clearEntryList();
 -            //worldEntriesList.empty();
++
+-
 +                const keywordHeaders = await renderTemplateAsync('worldInfoKeywordHeaders');
 -            const keywordHeaders = await renderTemplateAsync('worldInfoKeywordHeaders');
 +                const blocks = [];
 -            const blocksPromises = page.map(async (entry) => await getWorldEntry(name, data, entry)).filter(x => x);
++
 -            const blocks = await Promise.all(blocksPromises);
 +                for (const entry of page) {
 -            const isCustomOrder = $('#world_info_sort_order').find(':selected').data('rule') === 'custom';
 +                    try {
 -            if (!isCustomOrder) {
 +                        const block = await getWorldEntry(name, data, entry);
 -                blocks.forEach(block => {
 +                        if (block) {
 -                    block.find('.drag-handle').remove();
 +                            blocks.push(block);
 -                });
 +                        }
 +                    } catch (error) {
 +                        console.error(`Error while processing entry ${entry.uid}:`, error);
 +                    }
 +                }
++
 +                const isCustomOrder = $('#world_info_sort_order').find(':selected').data('rule') === 'custom';
 +                if (!isCustomOrder) {
 +                    blocks.forEach(block => {
 +                        block.find('.drag-handle').remove();
 +                    });
 +                }
++
 +                worldEntriesList.append(keywordHeaders);
 +                worldEntriesList.append(blocks);
 +            } catch (error) {
 +                console.error('Error while rendering WI entries:', error);
 +            } finally {
 +                isSaveWorldInfoDisabled = false;
+            }
 -            worldEntriesList.append(keywordHeaders);
 -            worldEntriesList.append(blocks);
         },
         afterSizeSelectorChange: function (e) {
             accountStorage.setItem(storageKey, e.target.value);

  * @return {Promise<void>} A promise that resolves when the world info is saved
  */
 export async function saveWorldInfo(name, data, immediately = false) {
 +    // Saving is temporarily disabled
 +    if (isSaveWorldInfoDisabled) {
 +        return;
 +    }
++
     if (!name || !data) {
         return;
+    }