fix: return Error objects from invokeFunctionTool and create error invocations (#5351) * fix: return Error objects from invokeFunctionTool and create error invocations invokeFunctionTool previously called .toString() on caught errors, converting them to plain strings. This made the instanceof Error check in invokeFunctionTools dead code. Changes: - Return Error objects directly from invokeFunctionTool - Create error invocations with error: true flag when tools fail - Record failed stealth tools in stealthCalls - Preserve signature/reasoning on error invocations - Add error field to ToolInvocation typedef * fix: use Error.toString to avoid behavioral changes --------- Co-authored-by: Cohee <18619528+Cohee1207@users.noreply.github.com>

b89293418d085f0e1522892dd65a9ca7da218177

Xiangzhe <32761048+xz-dev@users.noreply.github.com>

Signed

public/scripts/tool-calling.js+20 -4 Viewed

  * @property {string} result - The result of the tool invocation.
  * @property {string?} signature - The thought signature associated with the tool invocation.
  * @property {string?} reasoning - The plaintext reasoning associated with this tool call turn.
+ * @property {boolean} [error] - Whether the tool invocation failed.
  */
 /**
  * @typedef {object} ToolInvocationResult
- * @property {ToolInvocation[]} invocations Successful tool invocations
+ * @property {ToolInvocation[]} invocations Tool invocations (both successful and failed)
  * @property {Error[]} errors Errors that occurred during tool invocation
  * @property {string[]} stealthCalls Names of stealth tools that were invoked
  */

@@ -336,10 +337,10 @@ export class ToolManager {
336		337
337	if (error instanceof Error) {	338	if (error instanceof Error) {
338	error.cause = name;	339	error.cause = name;
339	return error.toString();	340	return error;
340	}	341	}
341		342
342	return new Error('Unknown error occurred while invoking the tool.', { cause: name }).toString();	343	return new Error('Unknown error occurred while invoking the tool.', { cause: name });
343	}	344	}
344	}	345	}
345		346

             toastr.clear(toast);
             console.log('[ToolManager] Function tool result:', result);
-            // Save a successful invocation
+            // Handle tool errors — still create an invocation so the LLM sees the failure
             if (toolResult instanceof Error) {
                 result.errors.push(toolResult);
+                if (isStealth) {
+                    result.stealthCalls.push(name);
+                } else {
+                    result.invocations.push({
+                        id,
+                        displayName,
+                        name,
+                        parameters: stringify(parameters),
+                        result: toolResult.toString(),
+                        error: true,
+                        signature: toolCall.signature || null,
+                        reasoning: reasoningText || null,
+                    });
+                }
                 continue;
+            }

                 name,
                 parameters: stringify(parameters),
                 result: toolResult,
+                error: false,
                 signature: toolCall.signature || null,
                 reasoning: reasoningText || null,
             };