Summarize: configurable system/user role for the summary prompt Reviewed-by: auto-review

d52580592541ecaef1873a8a81e59876a4634ed5

permissionBRICK <permissionBRICK@gmail.com>

Parents: c0a14545a4616d74737976c6257fa95ac2a97504

public/scripts/extensions/memory/index.js+62 -13 Viewed

     maxMessagesPerRequestMax: 250,
     maxMessagesPerRequestStep: 1,
     prompt_builder: prompt_builders.DEFAULT,
+    summaryPromptRole: extension_prompt_roles.SYSTEM,
 };
+/**
+ * Resolve the configured role for the summarization request prompt.
+ * Only SYSTEM and USER are supported; anything else falls back to SYSTEM.
+ * @returns {number} One of extension_prompt_roles.SYSTEM or extension_prompt_roles.USER
+ */
+function getSummaryPromptRole() {
+    return Number(extension_settings.memory.summaryPromptRole) === extension_prompt_roles.USER
+        ? extension_prompt_roles.USER
+        : extension_prompt_roles.SYSTEM;
+}
 function loadSettings() {
     if (Object.keys(extension_settings.memory).length === 0) {
         Object.assign(extension_settings.memory, defaultSettings);

     $('#memory_template').val(extension_settings.memory.template).trigger('input');
     $('#memory_depth').val(extension_settings.memory.depth).trigger('input');
     $('#memory_role').val(extension_settings.memory.role).trigger('input');
+    $('#memory_summary_prompt_role').val(extension_settings.memory.summaryPromptRole).trigger('input');
     $(`input[name="memory_position"][value="${extension_settings.memory.position}"]`).prop('checked', true).trigger('input');
     $('#memory_prompt_words_force').val(extension_settings.memory.promptForceWords).trigger('input');
     $(`input[name="memory_prompt_builder"][value="${extension_settings.memory.prompt_builder}"]`).prop('checked', true).trigger('input');

     saveSettingsDebounced();
+}
+function onMemorySummaryPromptRoleInput() {
+    const value = $(this).val();
+    extension_settings.memory.summaryPromptRole = Number(value);
+    saveSettingsDebounced();
+}
 function onMemoryPositionChange(e) {
     const value = e.target.value;
     extension_settings.memory.position = value;

     const source = args.source || extension_settings.memory.source;
     const prompt = substituteParamsExtended((args.prompt || extension_settings.memory.prompt), { words: extension_settings.memory.promptWords });
+    const useUserRole = getSummaryPromptRole() === extension_prompt_roles.USER;
     try {
         switch (source) {
             case summary_sources.extras:
                 return await callExtrasSummarizeAPI(text);
-            case summary_sources.main:
+            case summary_sources.main: {
-                return removeReasoningFromString(await generateRaw({ prompt: text, systemPrompt: prompt, responseLength: extension_settings.memory.overrideResponseLength }));
+                // When the instruction should be a USER message, combine it into the
+                // user content and clear the system prompt. Otherwise keep it as system.
+                const rawPrompt = useUserRole ? [prompt, text].filter(x => x).join('\n\n') : text;
+                const systemPrompt = useUserRole ? '' : prompt;
+                return removeReasoningFromString(await generateRaw({ prompt: rawPrompt, systemPrompt: systemPrompt, responseLength: extension_settings.memory.overrideResponseLength }));
+            }
             case summary_sources.webllm: {
-                const messages = [{ role: 'system', content: prompt }, { role: 'user', content: text }].filter(m => m.content);
+                const promptRole = useUserRole ? 'user' : 'system';
+                const messages = [{ role: promptRole, content: prompt }, { role: 'user', content: text }].filter(m => m.content);
                 const params = extension_settings.memory.overrideResponseLength > 0 ? { max_tokens: extension_settings.memory.overrideResponseLength } : {};
                 return await generateWebLlmChatPrompt(messages, params);
+            }

         return null;
+    }
+    const promptRole = getSummaryPromptRole() === extension_prompt_roles.USER ? 'user' : 'system';
     const messages = [
-        { role: 'system', content: prompt },
+        { role: promptRole, content: prompt },
         { role: 'user', content: rawPrompt },
     ];

     if (prompt_builders.DEFAULT === extension_settings.memory.prompt_builder) {
         try {
             inApiCall = true;
-            /** @type {import('../../../script.js').GenerateQuietPromptParams} */
+            // generateQuietPrompt always injects the instruction as a SYSTEM message
-            const params = {
+            // (the QUIET_PROMPT extension prompt has no exposed role parameter).
-                quietPrompt: prompt,
+            // When a USER role is requested, assemble the chat transcript ourselves
-                skipWIAN: skipWIAN,
+            // (same source as the raw builder) and deliver the instruction as USER
-                responseLength: extension_settings.memory.overrideResponseLength,
+            // content via generateRaw, so the model still receives the chat to
-            };
+            // summarize instead of just the bare instruction.
-            summary = await generateQuietPrompt(params);
+            if (getSummaryPromptRole() === extension_prompt_roles.USER) {
+                const { rawPrompt } = await getRawSummaryPrompt(context, prompt);
+                /** @type {import('../../../script.js').GenerateRawParams} */
+                const params = {
+                    prompt: [prompt, rawPrompt].filter(x => x).join('\n\n'),
+                    systemPrompt: '',
+                    responseLength: extension_settings.memory.overrideResponseLength,
+                };
+                summary = removeReasoningFromString(await generateRaw(params));
+            } else {
+                /** @type {import('../../../script.js').GenerateQuietPromptParams} */
+                const params = {
+                    quietPrompt: prompt,
+                    skipWIAN: skipWIAN,
+                    responseLength: extension_settings.memory.overrideResponseLength,
+                };
+                summary = await generateQuietPrompt(params);
+            }
         } finally {
             inApiCall = false;
+        }

                 return null;
+            }
+            // When the summary instruction should be a USER message, deliver it as
+            // user content and leave the system prompt empty. Otherwise keep the
+            // existing behavior of sending it as the system prompt.
+            const useUserRole = getSummaryPromptRole() === extension_prompt_roles.USER;
             /** @type {import('../../../script.js').GenerateRawParams} */
             const params = {
-                prompt: rawPrompt,
+                prompt: useUserRole ? [prompt, rawPrompt].filter(x => x).join('\n\n') : rawPrompt,
-                systemPrompt: prompt,
+                systemPrompt: useUserRole ? '' : prompt,
                 responseLength: extension_settings.memory.overrideResponseLength,
             };
             const rawSummary = await generateRaw(params);

     $('#memory_template').off('input').on('input', onMemoryTemplateInput);
     $('#memory_depth').off('input').on('input', onMemoryDepthInput);
     $('#memory_role').off('input').on('input', onMemoryRoleInput);
+    $('#memory_summary_prompt_role').off('input').on('input', onMemorySummaryPromptRoleInput);
     $('input[name="memory_position"]').off('change').on('change', onMemoryPositionChange);
     $('#memory_prompt_words_force').off('input').on('input', onMemoryPromptWordsForceInput);
     $('#memory_prompt_builder_default').off('input').on('input', onMemoryPromptBuilderInput);

public/scripts/extensions/memory/settings.html+6 -0 Viewed

                             </div>
                         </label>
                         <textarea id="memory_prompt" class="text_pole textarea_compact" rows="6" data-i18n="[placeholder]ext_sum_prompt_placeholder" placeholder="This prompt will be sent to AI to request the summary generation. &lcub;&lcub;words&rcub;&rcub; will resolve to the 'Number of words' parameter."></textarea>
+                        <label for="memory_summary_prompt_role" data-i18n="ext_sum_prompt_role">Summary Prompt Role</label>
+                        <select id="memory_summary_prompt_role" class="text_pole">
+                            <option value="0" data-i18n="System">System</option>
+                            <option value="1" data-i18n="User">User</option>
+                        </select>
+                        <small data-i18n="ext_sum_prompt_role_desc">The role used to send the summary request instruction to the model.</small>
                         <label for="memory_prompt_words"><span data-i18n="ext_sum_target_length_1">Target summary length</span> <span data-i18n="ext_sum_target_length_2">(</span><span id="memory_prompt_words_value"></span><span data-i18n="ext_sum_target_length_3"> words)</span></label>
                         <input id="memory_prompt_words" type="range" value="{{defaultSettings.promptWords}}" min="{{defaultSettings.promptMinWords}}" max="{{defaultSettings.promptMaxWords}}" step="{{defaultSettings.promptWordsStep}}" />
                         <label for="memory_override_response_length">