Tweaking activateNaturalOrder Changes to activateNaturalOrder to try to keep silent characters silent.

e097e42ff8dd28ac424f51466bc056f43bad5e5e

David Fedolfi <dfedolfi@gmail.com>

public/scripts/group-chats.js+10 -4 Viewed

@@ -1006,6 +1006,7 @@ function activateNaturalOrder(members, input, lastMessage, allowSelfResponses, i
1006	1006	}
1007	1007	}
1008	1008
	1009	+ let chattyMembers = [];
1009	1010	// activation by talkativeness (in shuffled order, except banned)
1010	1011	const shuffledMembers = shuffle([...members]);
1011	1012	for (let member of shuffledMembers) {

         if (talkativeness >= rollValue) {
             activatedMembers.push(member);
+        }
 +        if (talkativeness > 0){
 +            chattyMembers.push(member);
 +        }
+    }
     // pick 1 at random if no one was activated
     let retries = 0;
 -    while (activatedMembers.length === 0 && ++retries <= members.length) {
 +    // try to limit the selected random character to those with talkativeness > 0
 -        const randomIndex = Math.floor(Math.random() * members.length);
 +    let randomPool = chattyMembers.length > 0? chattyMembers : members;
 -        const character = characters.find((x) => x.avatar === members[randomIndex]);
 +    while (activatedMembers.length === 0 && ++retries <= randomPool.length) {
 +        const randomIndex = Math.floor(Math.random() * randomPool.length);
 +        const character = characters.find((x) => x.avatar === randomPool[randomIndex]);
         if (!character) {
             continue;
+        }
         activatedMembers.push(membersrandomPool[randomIndex]);
+    }
     // de-duplicate array of character avatars