Merge pull request #2455 from SillyTavern/sanitize-group-members validate group that all members exist

e8c5ce0669d1b1a52dd51959395b38d434b957fa

Cohee <18619528+Cohee1207@users.noreply.github.com>

Signed

public/scripts/group-chats.js+31 -5 Viewed

     return [];
+}
+async function validateGroup(group) {
+    if (!group) return;
+    // Validate that all members exist as characters
+    let dirty = false;
+    group.members = group.members.filter(member => {
+        const character = characters.find(x => x.avatar === member || x.name === member);
+        if (!character) {
+            const msg = `Warning: Listed member ${member} does not exist as a character. It will be removed from the group.`;
+            toastr.warning(msg, 'Group Validation');
+            console.warn(msg);
+            dirty = true;
+        }
+        return character;
+    });
+    if (dirty) {
+        await editGroup(group.id, true, false);
+    }
+}
 export async function getGroupChat(groupId, reload = false) {
     const group = groups.find((x) => x.id === groupId);
+    if (!group) {
+        console.warn('Group not found', groupId);
+        return;
+    }
+    // Run validation before any loading
+    validateGroup(group);
     const chat_id = group.chat_id;
     const data = await loadGroupChat(chat_id);
     let freshChat = false;

         if (group && Array.isArray(group.members)) {
             for (let member of group.members) {
                 const character = characters.find(x => x.avatar === member || x.name === member);
                 if (!character) {
                     continue;
+                }

         freshChat = true;
+    }
-    if (group) {
+    let metadata = group.chat_metadata ?? {};
-        let metadata = group.chat_metadata ?? {};
+    updateChatMetadata(metadata, true);
-        updateChatMetadata(metadata, true);
-    }
     if (reload) {
         select_group_chats(groupId, true);