chore: add arguments logging to deprecated MacrosParser method warnings (#5429) Extends the #logDeprecated helper to accept and log the arguments passed to deprecated methods, providing better debugging context for migration. Updates all deprecated method calls (get, has, registerMacro, unregisterMacro) to forward their arguments to the deprecation logger.

ff4c6fa1bbdfe76c8c4ce6c41a9aa9033901cef2

Wolfsblvt <wolfsblvt@gmail.com>

Signed

public/scripts/macros.js+7 -6 Viewed

+     *
      * @param {string} method
      * @param {string} replacement
 +     * @param {IArguments} [methodArgs=null]
      * @returns {void}
      */
     static #logDeprecated(method, replacement, methodArgs = null) {
         console.warn(`[DEPRECATED] MacrosParser.${method} is deprecated and will be removed in a future version. Use ${replacement} instead. Arguments:`, (methodArgs ?? 'none'));
+    }
     /**

      * @returns {string|MacroFunction|undefined} The macro value
      */
     static get(key) {
         MacrosParser.#logDeprecated('get', 'macros.registry.getMacro (from scripts/macros/macro-system.js)', arguments);
         return MacrosParser.#macros.get(key);
+    }

      * @returns {boolean} True if the macro is registered, false otherwise
      */
     static has(key) {
         MacrosParser.#logDeprecated('has', 'macros.registry.hasMacro (from scripts/macros/macro-system.js)', arguments);
         if (power_user.experimental_macro_engine) {
             return macroSystem.registry.hasMacro(key);
+        }

      * @param {string} [description] Optional description of the macro
      */
     static registerMacro(key, value, description = '') {
         MacrosParser.#logDeprecated('registerMacro', 'macros.registry.registerMacro (from scripts/macros/macro-system.js) or substituteParams({ dynamicMacros })', arguments);
         if (typeof key !== 'string') {
             throw new Error('Macro key must be a string');
+        }

      * @param {string} key Macro name (key)
      */
     static unregisterMacro(key) {
         MacrosParser.#logDeprecated('unregisterMacro', 'macros.registry.unregisterMacro (from scripts/macros/macro-system.js)', arguments);
         if (typeof key !== 'string') {
             throw new Error('Macro key must be a string');
+        }